From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH] KVM: x86: fixup set_efer()
Date: Thu, 9 Sep 2010 16:37:19 +0800
Message-ID: <201009091637.19440.sheng@linux.intel.com>
References: <AANLkTinMZiG6iGBv+PHBw_rsn1+SJaPtDA=-zHcU0Mrf@mail.gmail.com> <4C875FA2.40004@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Hillf Danton <dhillf@gmail.com>,
	"Ben-Ami Yassour" <benami@il.ibm.com>,
	Amit Shah <amit.shah@redhat.com>,
	Yaniv Kamay <ykamay@redhat.com>
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga02.intel.com ([134.134.136.20]:27855 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752394Ab0IIIgi (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 9 Sep 2010 04:36:38 -0400
In-Reply-To: <4C875FA2.40004@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wednesday 08 September 2010 18:04:18 Avi Kivity wrote:
>   On 09/04/2010 04:29 PM, Hillf Danton wrote:
> > The second call to kvm_mmu_reset_context() seems unnecessary and is
> > removed.
> > 
> > 
> > @@ -783,10 +783,6 @@ static int set_efer(struct kvm_vcpu *vcp
> > vcpu->arch.mmu.base_role.nxe = (efer & EFER_NX) && !tdp_enabled;
> > kvm_mmu_reset_context(vcpu);
> > - /* Update reserved bits */
> > - if ((efer ^ old_efer) & EFER_NX)
> > - kvm_mmu_reset_context(vcpu);
> > -
> > return 0;
> > 
> >  }
> 
> Hm.  As far as I can tell, it's the first call that is unnecessary.
> I'll look at the history and try to understand why it was introduced.

Oops, seems my patch failed to remove the old line...

--
regards
Yang, Sheng