Re: [PATCH] KVM: x86: fixup set_efer()

Avi Kivity
2010-09-08T10:04:26Z

On 09/04/2010 04:29 PM, Hillf Danton wrote:
> The second call to kvm_mmu_reset_context() seems unnecessary and is
> removed.
>
>
> @@ -783,10 +783,6 @@ static int set_efer(struct kvm_vcpu *vcp
> vcpu->arch.mmu.base_role.nxe = (efer & EFER_NX) && !tdp_enabled;
> kvm_mmu_reset_context(vcpu);
> - /* Update reserved bits */
> - if ((efer ^ old_efer) & EFER_NX)
> - kvm_mmu_reset_context(vcpu);
> -
> return 0;
> }

Hm. As far as I can tell, it's the first call that is unnecessary.
I'll look at the history and try to understand why it was introduced.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.