From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2 0/2] Emulate MSR_EBC_FREQUENCY_ID Date: Thu, 9 Sep 2010 16:53:21 -0300 Message-ID: <20100909195321.GA32178@amt.cnet> References: <1284026806-32624-1-git-send-email-Jes.Sorensen@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Jes.Sorensen@redhat.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37545 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755958Ab0IIT5K (ORCPT ); Thu, 9 Sep 2010 15:57:10 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o89JvAxU032657 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Sep 2010 15:57:10 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o89Jv5E7007384 for ; Thu, 9 Sep 2010 15:57:06 -0400 Received: from amt.cnet (vpn-11-249.rdu.redhat.com [10.11.11.249]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o89Jv4mF024954 for ; Thu, 9 Sep 2010 15:57:05 -0400 Received: from amt.cnet (localhost.localdomain [127.0.0.1]) by amt.cnet (Postfix) with ESMTP id EF4EA17A008 for ; Thu, 9 Sep 2010 16:56:41 -0300 (BRT) Content-Disposition: inline In-Reply-To: <1284026806-32624-1-git-send-email-Jes.Sorensen@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Sep 09, 2010 at 12:06:44PM +0200, Jes.Sorensen@redhat.com wrote: > From: Jes Sorensen > > Hi, > > Discussed this with Juan and he spotted this place in > arch/x86/kernel/cpu/cpufreq/speedstep-lib.c which relies on the 'Core > Clock Frequency to System Bus Frequency Ratio', so leaving it set to 0 > is not going to work. Reading the spec it also says that bits 31:24 > are reserved on models 0-1, so it should be safe to set it for this > case. > > Here is v2, which should hopefully do the right thing. > > Cheers, > Jes Applied, thanks.