From: Joerg Roedel <joro@8bytes.org>
To: Alexander Graf <agraf@suse.de>
Cc: Joerg Roedel <joerg.roedel@amd.com>, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features
Date: Sat, 11 Sep 2010 16:42:23 +0200 [thread overview]
Message-ID: <20100911144222.GC680@8bytes.org> (raw)
In-Reply-To: <A973F10B-EC12-4033-A431-0E88BA71C6F4@suse.de>
On Sat, Sep 11, 2010 at 04:38:51PM +0200, Alexander Graf wrote:
> > I am not sure that I am the right person to do such an invasive change.
> > At least not in this patch-set. I could think of removing SVM from the
> > qemu64 definition and add it again in the TCG specific path.
>
> It's not an invasive change and IMHO the only correct one. I'm not
> even sure why it's not done yet - after all the reason for the kvm*
> cpu types is exactly that. Please just add it as an early patch in
> your series.
Okay, if you say its ok I will change it. But if anyone comes to me with
regressions I will send them straight to you :-P
Joerg
next prev parent reply other threads:[~2010-09-11 14:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 15:38 [PATCH 0/2] Add SVM feature flags to qemu Joerg Roedel
2010-09-10 15:38 ` [PATCH 1/2] qemu-kvm: Set cpuid definition to 0 before initializing it Joerg Roedel
2010-09-10 15:38 ` [PATCH 2/2] qemu-kvm: Add svm cpuid features Joerg Roedel
2010-09-11 13:43 ` [Qemu-devel] " Alexander Graf
2010-09-11 14:20 ` Joerg Roedel
2010-09-11 14:29 ` Alexander Graf
2010-09-11 14:36 ` Joerg Roedel
2010-09-11 14:38 ` Alexander Graf
2010-09-11 14:42 ` Joerg Roedel [this message]
2010-09-11 14:45 ` Alexander Graf
2010-09-12 6:05 ` Avi Kivity
2010-09-12 7:16 ` Alexander Graf
2010-09-12 8:01 ` Avi Kivity
2010-09-12 10:06 ` Alexander Graf
2010-09-12 10:22 ` Avi Kivity
2010-09-12 11:14 ` Alexander Graf
2010-09-12 12:02 ` Avi Kivity
2010-09-12 14:30 ` Joerg Roedel
2010-09-12 14:36 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2010-09-18 22:16 garymberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100911144222.GC680@8bytes.org \
--to=joro@8bytes.org \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox