Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

Alexander Graf
2010-09-11T14:45:15Z

On 11.09.2010, at 16:42, Joerg Roedel wrote:

> On Sat, Sep 11, 2010 at 04:38:51PM +0200, Alexander Graf wrote:
>>> I am not sure that I am the right person to do such an invasive change.
>>> At least not in this patch-set. I could think of removing SVM from the
>>> qemu64 definition and add it again in the TCG specific path.
>>
>> It's not an invasive change and IMHO the only correct one. I'm not
>> even sure why it's not done yet - after all the reason for the kvm*
>> cpu types is exactly that. Please just add it as an early patch in
>> your series.
>
> Okay, if you say its ok I will change it. But if anyone comes to me with
> regressions I will send them straight to you :-P

Feel free to do so :). We really need to have a different default CPU for "migration safe KVM" and "This is what TCG can emulate". They don't match semantically.

Alex