public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: spice-devel@lists.freedesktop.org, rusty@rustcorp.com.au,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: PATCH: virtio_console: Fix poll blocking even though there is data to read (version 2)
Date: Thu, 16 Sep 2010 10:46:26 +0530	[thread overview]
Message-ID: <20100916051626.GA2429@amit-laptop.redhat.com> (raw)
In-Reply-To: <4C90E3BF.4000408@redhat.com>

On (Wed) Sep 15 2010 [17:18:23], Hans de Goede wrote:
> diff -up linux-2.6.35.x86_64/drivers/char/virtio_console.c~ linux-2.6.35.x86_64/drivers/char/virtio_console.c
> --- linux-2.6.35.x86_64/drivers/char/virtio_console.c~	2010-08-02 00:11:14.000000000 +0200
> +++ linux-2.6.35.x86_64/drivers/char/virtio_console.c	2010-09-15 13:39:29.043505000 +0200
> @@ -642,7 +642,7 @@ static unsigned int port_fops_poll(struc
>  	poll_wait(filp, &port->waitqueue, wait);
>  
>  	ret = 0;
> -	if (port->inbuf)
> +	if (port_has_data(port))
>  		ret |= POLLIN | POLLRDNORM;
>  	if (!will_write_block(port))
>  		ret |= POLLOUT;

Thanks, this works.

I'll send a git-formatted patch to Rusty.

		Amit

      reply	other threads:[~2010-09-16  5:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-15 15:18 PATCH: virtio_console: Fix poll blocking even though there is data to read (version 2) Hans de Goede
2010-09-16  5:16 ` Amit Shah [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100916051626.GA2429@amit-laptop.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=spice-devel@lists.freedesktop.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox