From mboxrd@z Thu Jan  1 00:00:00 1970
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: PATCH: virtio_console: Fix poll blocking even
 though there is data to read
Date: Thu, 16 Sep 2010 12:46:57 +0530
Message-ID: <20100916071657.GF2429@amit-laptop.redhat.com>
References: <4C90C475.4010809@redhat.com> <4C90CC11.70202@redhat.com>
	<20100915134624.GB12320@amit-laptop.redhat.com>
	<201009161532.55462.rusty@rustcorp.com.au>
	<20100916062201.GC2429@amit-laptop.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Cc: Michael Kerrisk <mtk.manpages@googlemail.com>,
	spice-devel@lists.freedesktop.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
To: Rusty Russell <rusty@rustcorp.com.au>
Return-path: <spice-devel-bounces+gcesd-spice-space-devel=m.gmane.org@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20100916062201.GC2429@amit-laptop.redhat.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/spice-devel>,
	<mailto:spice-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/spice-devel>
List-Post: <mailto:spice-devel@lists.freedesktop.org>
List-Help: <mailto:spice-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/spice-devel>,
	<mailto:spice-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: spice-devel-bounces+gcesd-spice-space-devel=m.gmane.org@lists.freedesktop.org
Errors-To: spice-devel-bounces+gcesd-spice-space-devel=m.gmane.org@lists.freedesktop.org
List-Id: kvm.vger.kernel.org

T24gKFRodSkgU2VwIDE2IDIwMTAgWzExOjUyOjAxXSwgQW1pdCBTaGFoIHdyb3RlOgo+IE9uIChU
aHUpIFNlcCAxNiAyMDEwIFsxNTozMjo1NF0sIFJ1c3R5IFJ1c3NlbGwgd3JvdGU6Cj4gPiBPbiBX
ZWQsIDE1IFNlcCAyMDEwIDExOjE2OjI0IHBtIEFtaXQgU2hhaCB3cm90ZToKPiA+ID4gT24gKFdl
ZCkgU2VwIDE1IDIwMTAgWzE1OjM3OjIxXSwgSGFucyBkZSBHb2VkZSB3cm90ZToKPiA+ID4gPiA+
Pi0tLSBsaW51eC0yLjYuMzUueDg2XzY0L2RyaXZlcnMvY2hhci92aXJ0aW9fY29uc29sZS5jfgky
MDEwLTA4LTAyIDAwOjExOjE0LjAwMDAwMDAwMCArMDIwMAo+ID4gPiA+ID4+KysrIGxpbnV4LTIu
Ni4zNS54ODZfNjQvZHJpdmVycy9jaGFyL3ZpcnRpb19jb25zb2xlLmMJMjAxMC0wOS0xNSAxMzoz
OToyOS4wNDM1MDUwMDAgKzAyMDAKPiA+ID4gPiA+PkBAIC02NDIsNyArNjQyLDcgQEAgc3RhdGlj
IHVuc2lnbmVkIGludCBwb3J0X2ZvcHNfcG9sbChzdHJ1Ywo+ID4gPiA+ID4+ICAJcG9sbF93YWl0
KGZpbHAsJnBvcnQtPndhaXRxdWV1ZSwgd2FpdCk7Cj4gPiA+ID4gPj4KPiA+ID4gPiA+PiAgCXJl
dCA9IDA7Cj4gPiA+ID4gPj4tCWlmIChwb3J0LT5pbmJ1ZikKPiA+ID4gPiA+PisJaWYgKCF3aWxs
X3JlYWRfYmxvY2socG9ydCkpCj4gPiA+ID4gPgo+ID4gPiA+ID5Mb29rcyBjb3JyZWN0LCBidXQg
dGhpcyBzaG91bGQgYmUKPiA+ID4gPiA+Cj4gPiA+ID4gPglpZiAocG9ydF9oYXNfZGF0YShwb3J0
KSkKPiA+ID4gPiA+Cj4gPiA+ID4gPmluc3RlYWQuCj4gPiA+ID4gCj4gPiA+ID4gVGhhdCBjZXJ0
YWlubHkgd29ya3MgZm9yIG1lIChhcyBpbiB3aWxsIHN0aWxsIGZpeCB0aGUgYnVnIEknbSBoaXR0
aW5nKSwgYnV0Cj4gPiA+ID4gcXVvdGluZyBmcm9tICJtYW4gMiBzZWxlY3QiOgo+ID4gPiA+IAo+
ID4gPiA+ICAgICAgICBUaHJlZSAgaW5kZXBlbmRlbnQgIHNldHMgb2YgZmlsZSBkZXNjcmlwdG9y
cyBhcmUgd2F0Y2hlZC4gIFRob3NlIGxpc3RlZAo+ID4gPiA+ICAgICAgICBpbiByZWFkZmRzIHdp
bGwgYmUgd2F0Y2hlZCB0byBzZWUgaWYgY2hhcmFjdGVycyAgYmVjb21lICBhdmFpbGFibGUgIGZv
cgo+ID4gPiA+ICAgICAgICByZWFkaW5nICAobW9yZSAgcHJlY2lzZWx5LCB0byBzZWUgaWYgYSBy
ZWFkIHdpbGwgbm90IGJsb2NrOyBpbiBwYXJ0aWN14oCQCj4gPiA+ID4gICAgICAgIGxhciwgYSBm
aWxlIGRlc2NyaXB0b3IgaXMgYWxzbyByZWFkeSBvbiBlbmQtb2YtZmlsZSkKPiA+ID4gPiAKPiA+
ID4gPiBOb3RpY2UgdGhlICJhIGZpbGUgZGVzY3JpcHRvciBpcyBhbHNvIHJlYWR5IG9uIGVuZC1v
Zi1maWxlIiwgYW5kCj4gPiA+ID4gcG9ydF9mb3BzX3JlYWQgdHJlYXRzIHRoZSBob3N0IG5vdCBi
ZWluZyBjb25uZWN0ZWQgYXMgZW9mIChpdCByZXR1cm5zIDAKPiA+ID4gPiBpbiB0aGF0IGNhc2Up
LiBTbyBmcm9tIGFuIEFQSSBwb3YgSSdtIG5vdCBzdXJlIHdoYXQgaXMgY29ycmVjdC4KPiA+ID4g
Cj4gPiA+IHBvbGwoMikgc2F5czoKPiA+ID4gCj4gPiA+ICAgICAgICAgICAgICAgUE9MTElOIFRo
ZXJlIGlzIGRhdGEgdG8gcmVhZC4KPiA+ID4gCj4gPiA+IFRoYXQgbWFrZXMgaXQgc2ltcGxlLgo+
ID4gCj4gPiBUaGF0J3MgYSBkb2N1bWVudGF0aW9uIGJ1Zy4gIE9uIGEgcGlwZSwgUE9MTElOIGlz
IHNldCB3aGVuIHRoZSBvdGhlciBlbmQKPiA+IGNsb3Nlcy4gIHJlYWQoKSB0aGVuIHJldHVybnMg
MCBpbW1lZGlhdGVseS4KPiAKPiBDdXJyZW50bHkgd2UgZG9uJ3Qgc2V0IFBPTExJTiB3aGVuIGhv
c3QgZ29lcyBkb3duLiAgSSdsbCBkbyBhIHNlY29uZAo+IHBhdGNoIGZvciB0aGF0Lgo+IAo+ID4g
cG9sbCgpIHNldHMgUE9MTElOIHdoZW4gcmVhZCgpIHdvbid0IGJsb2NrLCBhbmQgcGVvcGxlIGNv
dW50IG9uIGl0Lgo+IAo+IFllcywgdGhhdCdzIHRoZSBiZWhhdmlvdXIgd2l0aCBIYW5zJ3MgbmV3
IHBhdGNoIGFzIHdlbGwgLS0gdGhhdCdzIG5vdAo+IGNoYW5naW5nLgo+IAo+IFRoZSB3aWxsX3Jl
YWRfYmxvY2soKSBmdW5jdGlvbiAoYW5kIHRoZSBjb21tZW50IG9uIHRvcCBvZiBpdCkgYXJlCj4g
Y2F1c2luZyB0aGlzIGNvbmZ1c2lvbjoKPiAKPiAKPiAvKiBUaGUgY29uZGl0aW9uIHRoYXQgbXVz
dCBiZSB0cnVlIGZvciBwb2xsaW5nIHRvIGVuZCAqLwo+IHN0YXRpYyBib29sIHdpbGxfcmVhZF9i
bG9jayhzdHJ1Y3QgcG9ydCAqcG9ydCkKPiB7Cj4gCWlmICghcG9ydC0+Z3Vlc3RfY29ubmVjdGVk
KSB7Cj4gCQkvKiBQb3J0IGdvdCBob3QtdW5wbHVnZ2VkLiBMZXQncyBleGl0LiAqLwo+IAkJcmV0
dXJuIGZhbHNlOwo+IAl9Cj4gCXJldHVybiAhcG9ydF9oYXNfZGF0YShwb3J0KSAmJiBwb3J0LT5o
b3N0X2Nvbm5lY3RlZDsKPiB9Cj4gCj4gVGhpcyBmdW5jdGlvbiBpcyBvbmx5IGNhbGxlZCB0byB1
bmJsb2NrIGEgYmxvY2tpbmcgcmVhZCgpIGNhbGwuICBTbyB0aGUKPiBjb21tZW50IHRoZXJlIGhh
cyB0byBiZSBjaGFuZ2VkIHRvIHJlYWQgJ3dhaXRpbmcnIHRvIGVuZCBpbnN0ZWFkIG9mCj4gJ3Bv
bGxpbmcnIHRvIGVuZC4KPiAKPiByZWFkKCkgZG9lcyByZXR1cm4gMCBpbW1lZGlhdGVseSB3aGVu
IHRoZSBvdGhlciBlbmQgaXMgbm90IGNvbm5lY3RlZAo+IChhbmQgdGhlcmUncyBubyBkYXRhIHRv
IHJlYWQpLgo+IAo+IEluIGVmZmVjdCwgd2UgbmVlZDoKPiAtIEhhbnMncyBwYXRjaAo+IC0gYSBw
YXRjaCB0byBzZXQgUE9MTElOIHdoZW4gaG9zdCBnb2VzIGRvd24gKGluIGFkZGl0aW9uIHRvIFBP
TExIVVAgYW5kCj4gICBTSUdJTykKPiAtIGEgcGF0Y2ggdG8gY2hhbmdlIHRoZSBjb21tZW50IGZv
ciB3aWxsX3JlYWRfYmxvY2suCgpVaCwgc29ycnkgZm9yIGJsYWJiZXJpbmcuCgp3aWxsX3JlYWRf
YmxvY2soKSB3YXMgd3JpdHRlbiB0byBiZSB1c2VkIGluIHBvbGwoKSwgYW5kIHRoZSBjb21tZW50
IHNheXMKYXMgbXVjaC4gIEkgc2hvdWxkJ3ZlIHVzZWQgaXQgcmlnaHQgZnJvbSB0aGUgc3RhcnQu
ICBIYW5zJ3MgZmlyc3QgcGF0Y2gKd2FzIGNvcnJlY3QsIEknbGwgcGljayB0aGF0IHVwIGFuZCB0
aGF0IGFkZHJlc3NlcyBhbGwgdGhlICJpc3N1ZXMiIHRoYXQKYXJlIHByZXNlbnQuCgpTb3JyeSBh
Z2FpbiEKCgkJQW1pdApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpTcGljZS1kZXZlbCBtYWlsaW5nIGxpc3QKU3BpY2UtZGV2ZWxAbGlzdHMuZnJlZWRlc2t0
b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9zcGlj
ZS1kZXZlbAo=