From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] SVM: do not generate "external interrupt exit" if other exit is pending Date: Sun, 19 Sep 2010 19:29:41 +0200 Message-ID: <20100919172941.GF15338@8bytes.org> References: <20100919164127.GC3008@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com, joerg.roedel@amd.com, agraf@suse.de To: Gleb Natapov Return-path: Received: from 8bytes.org ([88.198.83.132]:50624 "EHLO 8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753693Ab0ISR3m (ORCPT ); Sun, 19 Sep 2010 13:29:42 -0400 Content-Disposition: inline In-Reply-To: <20100919164127.GC3008@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Sep 19, 2010 at 06:41:27PM +0200, Gleb Natapov wrote: > Nested SVM checks for external interrupt after injecting nested exception. > In case there is external interrupt pending the code generates "external > interrupt exit" and overwrites previous exit info. If previously injected > exception already generated exit it will be lost. Right. Have you seen specific mismehavior due to this problem? I am just curious how you found this :-) And another question, can you put the reason for this "if(...) return" into an comment before the statement? The whole svm-emulation thing is complicated enough so that we should document it well in the code :-) Joerg > > Signed-off-by: Gleb Natapov > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index 43f5558..1a1f86b 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -1707,6 +1707,9 @@ static inline bool nested_svm_intr(struct vcpu_svm *svm) > if (!(svm->vcpu.arch.hflags & HF_HIF_MASK)) > return false; > > + if (svm->nested.exit_required) > + return false; > + > svm->vmcb->control.exit_code = SVM_EXIT_INTR; > svm->vmcb->control.exit_info_1 = 0; > svm->vmcb->control.exit_info_2 = 0; > -- > Gleb.