From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] SVM: do not generate "external interrupt exit" if other exit is pending Date: Mon, 20 Sep 2010 09:40:07 +0200 Message-ID: <20100920074002.GF3008@redhat.com> References: <20100919164127.GC3008@redhat.com> <20100919172941.GF15338@8bytes.org> <20100919175027.GA12883@redhat.com> <20100919181933.GG15338@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com, joerg.roedel@amd.com, agraf@suse.de To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42803 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752887Ab0ITHkR (ORCPT ); Mon, 20 Sep 2010 03:40:17 -0400 Content-Disposition: inline In-Reply-To: <20100919181933.GG15338@8bytes.org> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Sep 19, 2010 at 08:19:33PM +0200, Joerg Roedel wrote: > On Sun, Sep 19, 2010 at 07:50:27PM +0200, Gleb Natapov wrote: > > On Sun, Sep 19, 2010 at 07:29:41PM +0200, Joerg Roedel wrote: > > > On Sun, Sep 19, 2010 at 06:41:27PM +0200, Gleb Natapov wrote: > > > > Nested SVM checks for external interrupt after injecting nested exception. > > > > In case there is external interrupt pending the code generates "external > > > > interrupt exit" and overwrites previous exit info. If previously injected > > > > exception already generated exit it will be lost. > > > > > > Right. Have you seen specific mismehavior due to this problem? I am just > > > curious how you found this :-) > > Yes. Trying to make async page fault work with nested svm :) It was hard > > to fix with reproducible test case. I am not dreaming to fix it just by > > code review. > > Interesting. Hope this was the only problem and you have it working now? > Yes. Now my test case works. -- Gleb.