From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: [PATCHv2] SVM: do not generate "external interrupt exit" if other exit is pending Date: Mon, 20 Sep 2010 10:51:49 +0200 Message-ID: <20100920085149.GM7972@amd.com> References: <20100920081532.GG3008@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: "kvm@vger.kernel.org" , "avi@redhat.com" , "mtosatti@redhat.com" , "agraf@suse.de" To: Gleb Natapov Return-path: Received: from va3ehsobe003.messaging.microsoft.com ([216.32.180.13]:29971 "EHLO VA3EHSOBE003.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752156Ab0ITJCV (ORCPT ); Mon, 20 Sep 2010 05:02:21 -0400 Content-Disposition: inline In-Reply-To: <20100920081532.GG3008@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Sep 20, 2010 at 04:15:32AM -0400, Gleb Natapov wrote: > Nested SVM checks for external interrupt after injecting nested exception. > In case there is external interrupt pending the code generates "external > interrupt exit" and overwrites previous exit info. If previously injected > exception already generated exit it will be lost. > > Signed-off-by: Gleb Natapov Acked-by: Joerg Roedel > --- > v1->v2 > - Added comment > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index 43f5558..ca778d5 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -1707,6 +1707,14 @@ static inline bool nested_svm_intr(struct vcpu_svm *svm) > if (!(svm->vcpu.arch.hflags & HF_HIF_MASK)) > return false; > > + /* > + * if vmexit was already requested (by intercepted exception > + * for instance) do not overwrite it with "external interrupt" > + * vmexit. > + */ > + if (svm->nested.exit_required) > + return false; > + > svm->vmcb->control.exit_code = SVM_EXIT_INTR; > svm->vmcb->control.exit_info_1 = 0; > svm->vmcb->control.exit_info_2 = 0; > -- > Gleb. > -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632