From: Marcelo Tosatti <mtosatti@redhat.com>
To: Zachary Amsden <zamsden@redhat.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>,
Glauber Costa <glommer@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [KVM timekeeping fixes 1/4] Fix kvmclock bug
Date: Mon, 20 Sep 2010 12:41:20 -0300 [thread overview]
Message-ID: <20100920154120.GB3088@amt.cnet> (raw)
In-Reply-To: <1284856695-19438-1-git-send-email-zamsden@redhat.com>
On Sat, Sep 18, 2010 at 02:38:12PM -1000, Zachary Amsden wrote:
> If preempted after kvmclock values are updated, but before hardware
> virtualization is entered, the last tsc time as read by the guest is
> never set. It underflows the next time kvmclock is updated if there
> has not yet been a successful entry / exit into hardware virt.
>
> Fix this by simply setting last_tsc to the newly read tsc value so
> that any computed nsec advance of kvmclock is nulled.
>
> Signed-off-by: Zachary Amsden <zamsden@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2010-09-20 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 0:38 [KVM timekeeping fixes 1/4] Fix kvmclock bug Zachary Amsden
2010-09-19 0:38 ` [KVM timekeeping fixes 2/4] Make math work for other scales Zachary Amsden
2010-09-19 0:38 ` [KVM timekeeping fixes 3/4] Rename timer function Zachary Amsden
2010-09-19 0:38 ` [KVM timekeeping fixes 4/4] TSC catchup mode Zachary Amsden
2010-09-20 15:38 ` Marcelo Tosatti
2010-09-21 1:11 ` Zachary Amsden
2010-09-21 18:18 ` Marcelo Tosatti
2010-09-22 19:25 ` Zachary Amsden
2010-09-23 19:57 ` Marcelo Tosatti
2010-09-20 15:41 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920154120.GB3088@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox