From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 0/9] msix/kvm integration cleanups Date: Mon, 20 Sep 2010 19:02:48 +0200 Message-ID: <20100920170247.GD29862@redhat.com> References: <1284995210-32432-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56736 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756974Ab0ITRIp (ORCPT ); Mon, 20 Sep 2010 13:08:45 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8KH8iRE022785 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Sep 2010 13:08:45 -0400 Content-Disposition: inline In-Reply-To: <1284995210-32432-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Sep 20, 2010 at 05:06:41PM +0200, Avi Kivity wrote: > This cleans up msix/kvm integration a bit. The really important patch is the > last one, which allows msix.o to be part of non-target-specific build. I actually thoought this later move should be done in a different way: - add all functions msix uses to kvm-stub.c - kvm_irq_routing_entry should also have a stub I sent some minor comments in case you have a reason to prefer this way. > Avi Kivity (9): > msix: avoid leaking kvm data on init failure > msix: make kvm specific initialization a function > msix: move kvm specific msix notify into a function > msix: move definitions from msix.c to msix.h > Add missing #include to hw/irq.h > msix: move kvm support functions to kvm-all.c and kvm-stub.c > msix: Move kvm_enabled() guards to kvm-all.c functions > Protect qemu-kvm.h declarations with NEED_CPU_H > Move msix.o build back to Makefile.objs > > Makefile.objs | 4 +- > Makefile.target | 4 - > hw/irq.h | 2 + > hw/msix.c | 173 ++++--------------------------------------------------- > hw/msix.h | 26 ++++++++ > kvm-all.c | 142 +++++++++++++++++++++++++++++++++++++++++++++ > kvm-stub.c | 29 +++++++++ > kvm.h | 16 +++++ > qemu-kvm.h | 21 ++++++- > 9 files changed, 247 insertions(+), 170 deletions(-) > > -- > 1.7.2.3