Re: [PATCH 0/9] msix/kvm integration cleanups

Michael S. Tsirkin
2010-09-20T17:08:45Z

On Mon, Sep 20, 2010 at 05:06:41PM +0200, Avi Kivity wrote:
> This cleans up msix/kvm integration a bit. The really important patch is the
> last one, which allows msix.o to be part of non-target-specific build.

I actually thoought this later move should be done in a different way:
- add all functions msix uses to kvm-stub.c
- kvm_irq_routing_entry should also have a stub

I sent some minor comments in case you have a reason
to prefer this way.

> Avi Kivity (9):
> msix: avoid leaking kvm data on init failure
> msix: make kvm specific initialization a function
> msix: move kvm specific msix notify into a function
> msix: move definitions from msix.c to msix.h
> Add missing #include to hw/irq.h
> msix: move kvm support functions to kvm-all.c and kvm-stub.c
> msix: Move kvm_enabled() guards to kvm-all.c functions
> Protect qemu-kvm.h declarations with NEED_CPU_H
> Move msix.o build back to Makefile.objs
>
> Makefile.objs | 4 +-
> Makefile.target | 4 -
> hw/irq.h | 2 +
> hw/msix.c | 173 ++++---------------------------------------------------
> hw/msix.h | 26 ++++++++
> kvm-all.c | 142 +++++++++++++++++++++++++++++++++++++++++++++
> kvm-stub.c | 29 +++++++++
> kvm.h | 16 +++++
> qemu-kvm.h | 21 ++++++-
> 9 files changed, 247 insertions(+), 170 deletions(-)
>
> --
> 1.7.2.3