Re: [PATCH 8/9] Protect qemu-kvm.h declarations with NEED_CPU_H

Avi Kivity
2010-09-21T16:04:00Z

On 09/20/2010 07:05 PM, Michael S. Tsirkin wrote:
> On Mon, Sep 20, 2010 at 05:06:49PM +0200, Avi Kivity wrote:
> > Target-specific definitions need to be qualified with NEED_CPU_H so kvm.h
> > can be included from non-target-specific files.
> >
> > Signed-off-by: Avi Kivity<avi@redhat.com>
>
> Long term, would be cleaner to split this into two files ...

Yes, this is a pain to deal with.

> > ---
> > kvm-stub.c | 1 +
> > qemu-kvm.h | 21 ++++++++++++++++++++-
> > 2 files changed, 21 insertions(+), 1 deletions(-)
> >
> > diff --git a/kvm-stub.c b/kvm-stub.c
> > index 37d2b7a..2e4bf00 100644
> > --- a/kvm-stub.c
> > +++ b/kvm-stub.c
> > @@ -169,3 +169,4 @@ bool kvm_msix_notify(PCIDevice *dev, unsigned vector)
> > {
> > return false;
> > }
> > +
>
> intentional?

Nope.

--
error compiling committee.c: too many arguments to function