From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 0/9] msix/kvm integration cleanups Date: Tue, 21 Sep 2010 18:14:21 +0200 Message-ID: <20100921161421.GD22845@redhat.com> References: <1284995210-32432-1-git-send-email-avi@redhat.com> <20100920170247.GD29862@redhat.com> <4C98D7B6.2010908@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61300 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757631Ab0IUQUR (ORCPT ); Tue, 21 Sep 2010 12:20:17 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8LGKHu3001339 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Sep 2010 12:20:17 -0400 Content-Disposition: inline In-Reply-To: <4C98D7B6.2010908@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Sep 21, 2010 at 06:05:10PM +0200, Avi Kivity wrote: > On 09/20/2010 07:02 PM, Michael S. Tsirkin wrote: > >On Mon, Sep 20, 2010 at 05:06:41PM +0200, Avi Kivity wrote: > >> This cleans up msix/kvm integration a bit. The really important patch is the > >> last one, which allows msix.o to be part of non-target-specific build. > > > >I actually thoought this later move should be done in a different way: > >- add all functions msix uses to kvm-stub.c > > Isn't that what I did? > > >- kvm_irq_routing_entry should also have a stub > > > >I sent some minor comments in case you have a reason > >to prefer this way. > > My motivation is really the last patch. If you explain what you'd > like to see I'll try to do it. Basically my idea was to avoid all ifdefs in msix.c *without changing it*, by stubbing out kvm APIs and structures we use there. -- MST