From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] support piix PAM registers in KVM
Date: Tue, 21 Sep 2010 16:06:01 -0300
Message-ID: <20100921190601.GA25269@amt.cnet>
References: <20100921123142.GB11145@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: seabios@seabios.org, kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:19700 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752420Ab0IVUuo (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 22 Sep 2010 16:50:44 -0400
Content-Disposition: inline
In-Reply-To: <20100921123142.GB11145@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Sep 21, 2010 at 02:31:42PM +0200, Gleb Natapov wrote:
> Without this BIOS fails to remap 0xf0000 memory from ROM to RAM so writes
> to F-segment modify ROM content instead of memory copy. Since QEMU does
> not reloads ROMs during reset on next boot modified copy of BIOS is used.
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 933ad86..0bf435d 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -99,10 +99,6 @@ static void i440fx_update_memory_mappings(PCII440FXState *d)
>      int i, r;
>      uint32_t smram, addr;
>  
> -    if (kvm_enabled()) {
> -        /* FIXME: Support remappings and protection changes. */
> -        return;
> -    }
>      update_pam(d, 0xf0000, 0x100000, (d->dev.config[I440FX_PAM] >> 4) & 3);
>      for(i = 0; i < 12; i++) {
>          r = (d->dev.config[(i >> 1) + (I440FX_PAM + 1)] >> ((i & 1) * 4)) & 3;
> --
> 			Gleb.

Ugh, we should support ro slots to avoid such kind of problems...

Applied, thanks.