From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: [PATCH 3/3] Add svm cpuid features Date: Mon, 27 Sep 2010 17:40:50 +0200 Message-ID: <20100927154049.GI9817@amd.com> References: <1285593377-1754-1-git-send-email-joerg.roedel@amd.com> <1285593377-1754-4-git-send-email-joerg.roedel@amd.com> <4CA0B116.4070107@redhat.com> <4CA0B1FF.8040903@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Marcelo Tosatti , Alexander Graf , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: Avi Kivity Return-path: Received: from tx2ehsobe003.messaging.microsoft.com ([65.55.88.13]:46800 "EHLO TX2EHSOBE006.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754697Ab0I0Pkl (ORCPT ); Mon, 27 Sep 2010 11:40:41 -0400 Content-Disposition: inline In-Reply-To: <4CA0B1FF.8040903@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Sep 27, 2010 at 11:02:23AM -0400, Avi Kivity wrote: > On 09/27/2010 04:58 PM, Avi Kivity wrote: > > On 09/27/2010 03:16 PM, Joerg Roedel wrote: > >> This patch adds the svm cpuid feature flags to the qemu > >> intialization path. It also adds the svm features available > >> on phenom to its cpu-definition and extends the host cpu > >> type to support all svm features KVM can provide. > >> > > > > This should really be "all svm features" since we'll later mask them > > with kvm capabilities. This way, if we later add more capabilities, > > we automatically gain support in userspace. Yes, that is what -cpu host does with these patches applied. The svm_features variable is set to -1 in this case and masked out later with the KVM capabilities. > > > > (or rather, all svm features that don't need save/restore support in > > userspace; I don't think any do, beyond svm itself) > > > > I applied 2 and 3 (to branch uq/master). If you want to add more svm > features, please send a patch. For patch 1, I'd like a review by > someone who understands the compat code. Great, thanks. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632