From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v11 13/17] Add mp(mediate passthru) device. Date: Tue, 28 Sep 2010 17:18:15 +0200 Message-ID: <201009281718.15813.arnd@arndb.de> References: <1285388855-27410-1-git-send-email-xiaohui.xin@intel.com> <201009281639.59417.arnd@arndb.de> <20100928144311.GB15294@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Ben Hutchings , xiaohui.xin@intel.com, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu, davem@davemloft.net, herbert@gondor.hengli.com.au, jdike@linux.intel.com, Sridhar Samudrala To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20100928144311.GB15294@redhat.com> Sender: netdev-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tuesday 28 September 2010, Michael S. Tsirkin wrote: > On Tue, Sep 28, 2010 at 04:39:59PM +0200, Arnd Bergmann wrote: > > Can you be more specific what the problem is? Do you think > > it breaks when a guest sends VLAN tagged frames or when macvtap > > is connected to a VLAN interface that adds another tag (or > > only the combination)? > > I expect the protocol value to be wrong when guest sends vlan tagged > frames as 802.1q frames have a different format. Ok, I see. Would that be fixed by using eth_type_trans()? I don't see any code in there that tries to deal with the VLAN tag, so do we have the same problem in the tun/tap driver? Also, I wonder how we handle the case where both the guest and the host do VLAN tagging. Does the host transparently override the guest tag, or does it add a nested tag? More importantly, what should it do? Arnd