From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 1/3] KVM: Emulation MSI-X mask bits for assigned devices Date: Thu, 30 Sep 2010 13:41:36 +0800 Message-ID: <201009301341.36766.sheng@linux.intel.com> References: <1285667052-24907-1-git-send-email-sheng@linux.intel.com> <1285667052-24907-2-git-send-email-sheng@linux.intel.com> <4CA2FA89.3010809@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mga14.intel.com ([143.182.124.37]:32669 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329Ab0I3Flr (ORCPT ); Thu, 30 Sep 2010 01:41:47 -0400 In-Reply-To: <4CA2FA89.3010809@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wednesday 29 September 2010 16:36:25 Avi Kivity wrote: > On 09/28/2010 11:44 AM, Sheng Yang wrote: > > This patch enable per-vector mask for assigned devices using MSI-X. > > > > + > > > > struct kvm_assigned_msix_entry { > > > > __u32 assigned_dev_id; > > __u32 gsi; > > __u16 entry; /* The index of entry in the MSI-X table */ > > > > - __u16 padding[3]; > > + __u16 flags; > > + __u16 padding[2]; > > > > }; > > Given that this field wasn't a flag field previously, we can't expect it > to be zero. So before we can check it, userspace needs to tell us that > is knows the field is not padding, but a flags field. > > You can use KVM_ENABLE_CAP for that. OK, I would use it. And it's per vcpu ioctl though, I would like to use it on setting for per vm. P.S. I would be offline till Oct.11 due to our holiday. -- regards Yang, Sheng