From: Ryan Harper <ryanh@us.ibm.com>
To: pradeep <psuriset@linux.vnet.ibm.com>
Cc: kvm@vger.kernel.org, mst@redhat.com, autotest@test.kernel.org
Subject: Re: [PATCH 18/18] KVM test: Add subtest of testing offload by ethtool
Date: Wed, 6 Oct 2010 10:55:45 -0500 [thread overview]
Message-ID: <20101006155545.GF23351@us.ibm.com> (raw)
In-Reply-To: <20101006142646.09c45a03@skywalker>
* pradeep <psuriset@linux.vnet.ibm.com> [2010-10-06 03:57]:
> On Mon, 27 Sep 2010 18:44:04 -0400
> Lucas Meneghel Rodrigues <lmr@redhat.com> wrote:
>
>
> > +
> > + vm = kvm_test_utils.get_living_vm(env, params.get("main_vm"))
> > + session = kvm_test_utils.wait_for_login(vm,
> > + timeout=int(params.get("login_timeout", 360)))
> > + # Let's just error the test if we identify that there's no
> > ethtool installed
> > + if session.get_command_status("ethtool -h"):
> > + raise error.TestError("Command ethtool not installed on
> > guest")
> > + session2 = kvm_test_utils.wait_for_login(vm,
> > + timeout=int(params.get("login_timeout", 360)))
> > + mtu = 1514
> > + feature_status = {}
> > + filename = "/tmp/ethtool.dd"
> > + guest_ip = vm.get_address()
> > + ethname = kvm_test_utils.get_linux_ifname(session,
> > vm.get_mac_address(0))
> > + supported_features = params.get("supported_features").split()
>
> I guess split this expects input.
>
> 23:48:03 ERROR| Test failed: AttributeError: 'NoneType' object has no
> attribute 'split'
That'll need an update to the tests_base.cfg file to ensure the test
type has that config value set.
Did the patchset miss updating tests_base.cfg.sample with this one ?
>
> 22.12', '00:1a:4a:65:09:09': '192.168.122.66', '9a:52:2f:62:12:63':
> '192.168.122.151', '9a:52:2f:62:6b:28': '192.168.122.35'}, 'version':
> 0, 'tcpdump': <kvm_subprocess.kvm_tail instance at 0x27cb200>} 23:48:05
> INFO | ['iteration.1'] 23:48:05 ERROR| Exception escaping from test:
> Traceback (most recent call last): File
> "/home/pradeep/vhost_net/autotest/client/common_lib/test.py", line 412,
> in _exec _call_test_function(self.execute, *p_args, **p_dargs) File
> "/home/pradeep/vhost_net/autotest/client/common_lib/test.py", line 605,
> in _call_test_function raise error.UnhandledTestFail(e)
> UnhandledTestFail: Unhandled AttributeError: 'NoneType' object has no
> attribute 'split' Traceback (most recent call last): File
> "/home/pradeep/vhost_net/autotest/client/common_lib/test.py", line 598,
> in _call_test_function return func(*args, **dargs) File
> "/home/pradeep/vhost_net/autotest/client/common_lib/test.py", line 284,
> in execute postprocess_profiled_run, args, dargs) File
> "/home/pradeep/vhost_net/autotest/client/common_lib/test.py", line 202,
> in _call_run_once self.run_once_profiling(postprocess_profiled_run,
> *args, **dargs) File
> "/home/pradeep/vhost_net/autotest/client/common_lib/test.py", line 308,
> in run_once_profiling self.run_once(*args, **dargs) File
> "/home/pradeep/vhost_net/autotest/client/tests/kvm/kvm.py", line 73, in
> run_once run_func(self, params, env) File
> "/home/pradeep/vhost_net/autotest/client/tests/kvm/tests/ethtool.py",
> line 185, in run_ethtool supported_features =
> params.get("supported_features").split() AttributeError: 'NoneType'
> object has no attribute 'split'
>
>
>
> --Pradeep
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com
next prev parent reply other threads:[~2010-10-06 15:55 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 22:43 [PATCH 00/18] Network Patchset v4 Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 01/18] KVM test: Add a new macaddress pool algorithm Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 02/18] KVM test: Make physical_resources_check to work with MAC management Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 03/18] KVM test: Remove address_pools.cfg dependency Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 04/18] KVM test: Add a get_ifname function Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 05/18] KVM Test: Add nw related functions ping and get_linux_ifname Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 06/18] KVM test: Add a new subtest ping Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 07/18] KVM test: Add a subtest jumbo Lucas Meneghel Rodrigues
2010-09-29 6:42 ` pradeep
2010-09-29 11:07 ` Lucas Meneghel Rodrigues
2010-09-29 11:33 ` pradeep
2010-09-29 20:21 ` Lucas Meneghel Rodrigues
2010-09-30 7:05 ` pradeep
2010-09-27 22:43 ` [PATCH 08/18] KVM test: Add basic file transfer test Lucas Meneghel Rodrigues
2010-09-28 13:24 ` Michael S. Tsirkin
2010-09-29 11:45 ` pradeep
2010-09-29 12:33 ` Lucas Meneghel Rodrigues
2010-09-29 14:08 ` Lucas Meneghel Rodrigues
2010-09-29 17:43 ` Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 09/18] KVM test: Add a subtest of load/unload nic driver Lucas Meneghel Rodrigues
2010-10-06 5:49 ` Amos Kong
2010-09-27 22:43 ` [PATCH 10/18] KVM test: Add a subtest of nic promisc Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 11/18] KVM test: Add a subtest of multicast Lucas Meneghel Rodrigues
2010-09-30 9:30 ` pradeep
2010-10-05 12:21 ` Amos Kong
2010-10-05 12:44 ` Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 12/18] KVM test: Add a subtest of pxe Lucas Meneghel Rodrigues
2010-09-27 22:43 ` [PATCH 13/18] KVM test: Add a subtest of changing MAC address Lucas Meneghel Rodrigues
2010-09-30 8:21 ` pradeep
2010-09-27 22:44 ` [PATCH 14/18] KVM test: Add a netperf subtest Lucas Meneghel Rodrigues
2010-10-05 9:00 ` pradeep
2010-10-05 12:59 ` Amos Kong
2010-10-06 10:48 ` pradeep
2010-09-27 22:44 ` [PATCH 15/18] KVM test: kvm_utils - Add support of check if remote port free Lucas Meneghel Rodrigues
2010-09-27 22:44 ` [PATCH 16/18] KVM test: Improve vlan subtest Lucas Meneghel Rodrigues
2010-09-30 6:59 ` pradeep
2010-10-05 12:56 ` Amos Kong
2010-09-27 22:44 ` [PATCH 17/18] KVM test: vlan subtest - Replace extra_params '-snapshot' with image_snapshot Lucas Meneghel Rodrigues
2010-09-27 22:44 ` [PATCH 18/18] KVM test: Add subtest of testing offload by ethtool Lucas Meneghel Rodrigues
2010-10-06 8:56 ` pradeep
2010-10-06 9:59 ` [Autotest] " pradeep
2010-10-06 15:55 ` Ryan Harper [this message]
2010-10-06 16:57 ` Lucas Meneghel Rodrigues
2010-10-07 2:09 ` [PATCH 00/18] Network Patchset v4 Lucas Meneghel Rodrigues
2010-10-07 13:45 ` [Autotest] " pradeep
2010-10-07 13:54 ` Lucas Meneghel Rodrigues
2010-10-07 14:37 ` pradeep
2010-10-07 15:00 ` [Autotest] " Michael S. Tsirkin
2010-10-08 12:27 ` Lucas Meneghel Rodrigues
-- strict thread matches above, loose matches on Subject: below --
2010-09-14 22:25 [PATCH 00/18] KVM autotest network patchset v3 Lucas Meneghel Rodrigues
2010-09-14 22:25 ` [PATCH 18/18] KVM test: Add subtest of testing offload by ethtool Lucas Meneghel Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006155545.GF23351@us.ibm.com \
--to=ryanh@us.ibm.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=psuriset@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox