From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 3/3] Add svm cpuid features Date: Wed, 6 Oct 2010 15:57:37 -0300 Message-ID: <20101006185737.GB8237@amt.cnet> References: <1285593377-1754-1-git-send-email-joerg.roedel@amd.com> <1285593377-1754-4-git-send-email-joerg.roedel@amd.com> <4CA0B116.4070107@redhat.com> <4CA0B1FF.8040903@redhat.com> <20100927154049.GI9817@amd.com> <4CA0C4B5.2010303@redhat.com> <20100928092851.GK9817@amd.com> <4CA1B776.20105@redhat.com> <20100928100520.GL9817@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Alexander Graf , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: "Roedel, Joerg" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47333 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933033Ab0JFS6n (ORCPT ); Wed, 6 Oct 2010 14:58:43 -0400 Content-Disposition: inline In-Reply-To: <20100928100520.GL9817@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Sep 28, 2010 at 12:05:20PM +0200, Roedel, Joerg wrote: > On Tue, Sep 28, 2010 at 05:37:58AM -0400, Avi Kivity wrote: > > On 09/28/2010 11:28 AM, Roedel, Joerg wrote: > > > > Weird, it worked here as I tested it. I had it on qemu/master and with > > > all three patches. But patch 1 should not make the difference. I take a > > > look, have you pushed the failing uq/master? > > > > Yes, 8fe6a21c76. > > > > > What was your command line? > > > > qemu-system-x86_64 -m 2G -cpu kvm64,+svm,+npt -enable-kvm ... > > > > Note this is qemu.git, so -enable-kvm is needed. > > Ok, I apparently forgot to force the CPUID xlevel to be 0x8000000A when > SVM is enabled, probably because I only tested CPUID models where xlevel > already defaults to 0x8000000A. Attached is a fix, thanks for catching > this. > > Joerg Applied, thanks.