From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] trace "exit to userspace" event
Date: Thu, 7 Oct 2010 13:18:39 -0300
Message-ID: <20101007161839.GA31784@amt.cnet>
References: <20101005131432.GO11145@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: avi@redhat.com, kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:24971 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751681Ab0JGQZw (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 7 Oct 2010 12:25:52 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o97GPpi3016075
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Thu, 7 Oct 2010 12:25:51 -0400
Content-Disposition: inline
In-Reply-To: <20101005131432.GO11145@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Oct 05, 2010 at 03:14:32PM +0200, Gleb Natapov wrote:
> Add tracepoint for userspace exit.
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
> index 6dd3a51..fb44da0 100644
> --- a/include/trace/events/kvm.h
> +++ b/include/trace/events/kvm.h
> @@ -6,6 +6,31 @@
>  #undef TRACE_SYSTEM
>  #define TRACE_SYSTEM kvm
>  
> +#define ERSN(x) { KVM_EXIT_##x, "KVM_EXIT_" #x }
> +
> +#define kvm_trace_exit_reason						\
> +	ERSN(UNKNOWN), ERSN(EXCEPTION), ERSN(IO), ERSN(HYPERCALL),	\
> +	ERSN(DEBUG), ERSN(HLT), ERSN(MMIO), ERSN(IRQ_WINDOW_OPEN),	\
> +	ERSN(SHUTDOWN), ERSN(FAIL_ENTRY), ERSN(INTR), ERSN(SET_TPR),	\
> +	ERSN(TPR_ACCESS), ERSN(S390_SIEIC), ERSN(S390_RESET), ERSN(DCR),\
> +	ERSN(NMI), ERSN(INTERNAL_ERROR), ERSN(OSI)
> +
> +TRACE_EVENT(kvm_userspace_exit,
> +	    TP_PROTO(__u32 reason),
> +	    TP_ARGS(reason),
> +
> +	TP_STRUCT__entry(
> +		__field(	__u32,		reason		)
> +	),
> +
> +	TP_fast_assign(
> +		__entry->reason		= reason;
> +	),
> +
> +	TP_printk("reason %s", __print_symbolic(__entry->reason,
> +						kvm_trace_exit_reason))
> +);
> +
>  #if defined(__KVM_HAVE_IOAPIC)
>  TRACE_EVENT(kvm_set_irq,
>  	TP_PROTO(unsigned int gsi, int level, int irq_source_id),
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index b8499f5..8800713 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1458,6 +1458,8 @@ static long kvm_vcpu_ioctl(struct file *filp,
>  		if (arg)
>  			goto out;
>  		r = kvm_arch_vcpu_ioctl_run(vcpu, vcpu->run);
> +		if (r >= 0)
> +			trace_kvm_userspace_exit(vcpu->run->exit_reason);
>  		break;
>  	case KVM_GET_REGS: {
>  		struct kvm_regs *kvm_regs;
> --
> 			Gleb.

Exit codes are also valid for r == -EINTR and -EAGAIN cases, eg
EXIT_INTR. Better print it out for all cases, and let the reader
decide whether exit_reason is valid.