From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
avi@redhat.com, Rusty Russell <rusty@rustcorp.com.au>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH] kvm: add oom notifier for virtio balloon
Date: Fri, 8 Oct 2010 18:39:16 +0530 [thread overview]
Message-ID: <20101008130916.GC5327@balbir.in.ibm.com> (raw)
In-Reply-To: <20101005124521.GA2602@darkstar>
* Dave Young <hidave.darkstar@gmail.com> [2010-10-05 20:45:21]:
> Balloon could cause guest memory oom killing and panic.
>
> Add oom notify to leak some memory and retry fill balloon after 5 minutes.
>
> At the same time add a mutex to protect balloon operations
> because we need leak balloon in oom notifier and give back freed value.
>
> Thanks Anthony Liguori for his sugestion about inflate retrying.
> Sometimes it will cause endless inflate/oom/delay loop,
> so I think next step is to add an option to do noretry-when-oom balloon.
>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Won't __GFP_NORETRY prevent OOM? Could you please describe how you
tested the patch?
--
Three Cheers,
Balbir
next prev parent reply other threads:[~2010-10-08 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 12:45 [PATCH] kvm: add oom notifier for virtio balloon Dave Young
2010-10-06 9:05 ` Rusty Russell
2010-10-06 13:50 ` Dave Young
2010-10-08 10:24 ` Dave Young
2010-10-08 13:09 ` Balbir Singh [this message]
2010-10-08 13:33 ` Dave Young
2010-10-08 15:53 ` Balbir Singh
2010-10-09 3:19 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008130916.GC5327@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=hidave.darkstar@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox