From mboxrd@z Thu Jan  1 00:00:00 1970
From: Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH] kvm: add oom notifier for virtio balloon
Date: Fri, 8 Oct 2010 18:39:16 +0530
Message-ID: <20101008130916.GC5327@balbir.in.ibm.com>
References: <20101005124521.GA2602@darkstar>
Reply-To: balbir@linux.vnet.ibm.com
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, avi@redhat.com,
	Rusty Russell <rusty@rustcorp.com.au>,
	Anthony Liguori <anthony@codemonkey.ws>
To: Dave Young <hidave.darkstar@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20101005124521.GA2602@darkstar>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

* Dave Young <hidave.darkstar@gmail.com> [2010-10-05 20:45:21]:

> Balloon could cause guest memory oom killing and panic.
> 
> Add oom notify to leak some memory and retry fill balloon after 5 minutes.
> 
> At the same time add a mutex to protect balloon operations
> because we need leak balloon in oom notifier and give back freed value. 
> 
> Thanks Anthony Liguori for his sugestion about inflate retrying.
> Sometimes it will cause endless inflate/oom/delay loop,
> so I think next step is to add an option to do noretry-when-oom balloon.
> 
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>

Won't __GFP_NORETRY prevent OOM? Could you please describe how you
tested the patch?

-- 
	Three Cheers,
	Balbir