public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: rusty@rustcorp.com.au
Cc: Christoph Hellwig <hch@infradead.org>,
	Ryan Harper <ryanh@us.ibm.com>, Tejun Heo <tj@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	dm-devel@redhat.com, Vivek Goyal <vgoyal@redhat.com>,
	john.cooper@redhat.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [2.6.36 REGRESSION] Re: virtio-blk: put request that was created to retrieve the device id
Date: Fri, 8 Oct 2010 12:06:44 -0400	[thread overview]
Message-ID: <20101008160643.GA32005@redhat.com> (raw)
In-Reply-To: <20100921210033.GA24729@infradead.org>

Hi Rusty,

On Tue, Sep 21 2010 at  5:00pm -0400,
Christoph Hellwig <hch@infradead.org> wrote:

> On Fri, Sep 17, 2010 at 09:58:48AM -0500, Ryan Harper wrote:
> > Since __bio_map_kern() sets up bio->bi_end_io = bio_map_kern_endio
> > (which does a bio_put(bio)) doesn't that ensure we don't leak?
> 
> Indeed, that should take care of it.
> 

We need to fix this regression for 2.6.36.  Not sure what else I need to
do to get this on your radar.  It's a pretty significant show-stopper
for 2.6.36 guests that use virtio-blk with a udev enabled distro.

Here is a reference to my original patch (which Ryan and hch have both
reviewed): https://patchwork.kernel.org/patch/165571/

Thanks,
Mike

  reply	other threads:[~2010-10-08 16:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100902032246.GA31484@redhat.com>
2010-09-09 15:26 ` [REGRESSION][BISECTED] virtio-blk serial attribute causes guest to hang [Was: Re: [PATCH UPDATED 4/5] dm: implement REQ_FLUSH/FUA support for request-based dm] Mike Snitzer
2010-09-09 15:44   ` Ryan Harper
2010-09-09 15:57     ` Mike Snitzer
2010-09-09 16:03       ` Ryan Harper
2010-09-09 17:55         ` Mike Snitzer
2010-09-09 18:35           ` Ryan Harper
2010-09-09 19:15             ` Mike Snitzer
2010-09-09 19:43               ` Mike Snitzer
2010-09-09 20:14                 ` Mike Snitzer
2010-09-09 20:30                   ` Ryan Harper
2010-09-09 21:00                     ` [PATCH] virtio-blk: put request that was created to retrieve the device id Mike Snitzer
2010-09-09 21:15                       ` Christoph Hellwig
2010-09-17 14:58                         ` Ryan Harper
2010-09-21 21:00                           ` Christoph Hellwig
2010-10-08 16:06                             ` Mike Snitzer [this message]
2010-10-09  1:41                       ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101008160643.GA32005@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@infradead.org \
    --cc=john.cooper@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=ryanh@us.ibm.com \
    --cc=tj@kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox