From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 2/2] kvm, MCE, Send SRAR SIGBUS directly Date: Fri, 8 Oct 2010 21:37:08 -0300 Message-ID: <20101009003708.GA18859@amt.cnet> References: <1286526255.7768.96.camel@yhuang-dev> <20101008202501.GA2291@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , "kvm@vger.kernel.org" , Andi Kleen , "linux-kernel@vger.kernel.org" , Dean Nelson To: Huang Ying Return-path: Content-Disposition: inline In-Reply-To: <20101008202501.GA2291@amt.cnet> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Fri, Oct 08, 2010 at 05:25:01PM -0300, Marcelo Tosatti wrote: > On Fri, Oct 08, 2010 at 04:24:15PM +0800, Huang Ying wrote: > > Originally, SRAR SIGBUS is sent to QEMU-KVM via touching the poisoned > > page. But commit 96054569190bdec375fe824e48ca1f4e3b53dd36 prevents the > > signal from being sent. So now the signal is sent via > > force_sig_info_fault directly. > > > > Reported-by: Dean Nelson > > Signed-off-by: Huang Ying > > --- > > arch/x86/include/asm/signal.h | 3 +++ > > arch/x86/kvm/mmu.c | 15 +++------------ > > arch/x86/mm/fault.c | 6 +++--- > > 3 files changed, 9 insertions(+), 15 deletions(-) > > > > static int kvm_handle_bad_page(struct kvm *kvm, gfn_t gfn, pfn_t pfn) > > { > > kvm_release_pfn_clean(pfn); > > if (is_hwpoison_pfn(pfn)) { > > - kvm_send_hwpoison_signal(kvm, gfn); > > + force_sig_info_fault(SIGBUS, BUS_MCEERR_AR, > > + gfn_to_hva(kvm, gfn), current); > > return 0; > > } else if (is_fault_pfn(pfn)) > > return -EFAULT; > > Better fill siginfo and use force_sig_info, which is already exported. Thats wrong, its not exported. But there is no need to force delivery, so i've changed it to use send_sig_info. Applied the other patches, thanks.