From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2 0/8] Move msix.o back to target independent files list Date: Sun, 10 Oct 2010 17:02:54 +0200 Message-ID: <20101010150253.GA5570@redhat.com> References: <1286721727-31447-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:6728 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751707Ab0JJPJI (ORCPT ); Sun, 10 Oct 2010 11:09:08 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9AF983c010971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 10 Oct 2010 11:09:08 -0400 Content-Disposition: inline In-Reply-To: <1286721727-31447-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Oct 10, 2010 at 04:41:59PM +0200, Avi Kivity wrote: > Due to a depedency on kvm's msix support, msix.c was changed to be a target > dependent file. This patch set changes it back. Nothing to object to here :). FWIW Acked-by: Michael S. Tsirkin > v2: make the msix.c->kvm.c interface at a finer granularity, removing the need > for kvm code to know about PCIDevice. > > Avi Kivity (8): > msix: avoid leaking kvm data on init failure > kvm: drop kvm_context parameter from msix-related kvm functions > Avoid using kvm_irq_routing_entry in PCIDevice > Avoid use of kvm_irq_routing_entry in hw/msix.c > kvm: Add stubs for msix support code > kvm: allow kvm.h to be included from target independent files > msix: remove CONFIG_KVM depedency > Move msix.o build back to Makefile.objs > > Makefile.objs | 4 +-- > Makefile.target | 4 -- > hw/device-assignment.c | 14 ++++---- > hw/msix.c | 82 ++++++++++++++++++++++++------------------------ > hw/pci.h | 9 +++++- > kvm-stub.c | 35 ++++++++++++++++++++ > kvm.h | 22 +++++++++++-- > qemu-kvm-x86.c | 14 ++++---- > qemu-kvm.c | 77 ++++++++++++++++++++++++++++++++++++-------- > qemu-kvm.h | 55 ++++---------------------------- > roms/seabios | 2 +- > 11 files changed, 189 insertions(+), 129 deletions(-) > > -- > 1.7.3.1