From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: system_powerdown not working for qemu-kvm 0.12.4? Date: Tue, 12 Oct 2010 09:14:04 +0200 Message-ID: <20101012071404.GA18974@redhat.com> References: <4BEFDC8D.70007@redhat.com> <4BF41051.2010608@redhat.com> <4C67C8D2.5000400@redhat.com> <4CB341E4.3060400@redhat.com> <4CB40515.2030809@redhat.com> <20101012071124.GA10190@morn.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Ruben Kerkhof , Teck Choon Giam , kvm@vger.kernel.org, seabios@seabios.org To: "Kevin O'Connor" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31020 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755669Ab0JLHOX (ORCPT ); Tue, 12 Oct 2010 03:14:23 -0400 Content-Disposition: inline In-Reply-To: <20101012071124.GA10190@morn.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Oct 12, 2010 at 03:11:24AM -0400, Kevin O'Connor wrote: > On Tue, Oct 12, 2010 at 08:49:58AM +0200, Avi Kivity wrote: > > On 10/11/2010 07:53 PM, Ruben Kerkhof wrote: > > >5c99b6c984682ddb1d4543a7e27a1f4ca633e6a6 is the first bad commit > > >commit 5c99b6c984682ddb1d4543a7e27a1f4ca633e6a6 > > >Author: Kevin O'Connor > > Gleb, Kevin, any ideas? > > > > (summary: qemu-kvm doesn't acpi shutdown freebsd 8.1 with this > > commit; qemu.git does. May be due to interrupt polarity which kvm > > implements but qemu does not) > > The only thing in commit 5c99b6c9 that could cause an issue is that it > has the compiled acpi changes actually made in commit 29f4b912, but I > don't see how that would be a problem to reboots: > It makes line 0 of device 1 to be active low instead of active high. > diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl > index cee038a..2bede25 100644 > --- a/src/acpi-dsdt.dsl > +++ b/src/acpi-dsdt.dsl > @@ -58,7 +58,10 @@ DefinitionBlock ( > #define prt_slot2(nr) prt_slot(nr, LNKB, LNKC, LNKD, LNKA) > #define prt_slot3(nr) prt_slot(nr, LNKC, LNKD, LNKA, LNKB) > prt_slot0(0x0000), > - prt_slot1(0x0001), > + Package() { 0x0001ffff, 0, 0, 9 }, > + Package() { 0x0001ffff, 1, LNKB, 0 }, > + Package() { 0x0001ffff, 2, LNKC, 0 }, > + Package() { 0x0001ffff, 3, LNKD, 0 }, > prt_slot2(0x0002), > prt_slot3(0x0003), > prt_slot0(0x0004), > > Can you confirm that commit 4c94b7ea works reliably while commit > 5c99b6c9 does not? > > -Kevin -- Gleb.