public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: joerg.roedel@amd.com
Cc: kvm@vger.kernel.org
Subject: question about nested ntp
Date: Tue, 12 Oct 2010 15:26:11 +0200	[thread overview]
Message-ID: <20101012132611.GA28070@redhat.com> (raw)

Hi Joerg,

I have a question about nested ntp code. Comment in init_kvm_nested_mmu()
function says "arch.mmu.gva_to_gpa translates l2_gva to l1_gpa". If
I read the code correctly at the time of nested guest execution
arch.mmu.gva_to_gpa() points to one of paging*_gva_to_gpa() variants. The
function calls walk_addr() with provided address which should be
l2_gva according to the comment.  Now when NPF happens while nested
guest runs arch.mmu.page_fault() is called which translates to call
to one of paging*_page_fault() variants.  paging*_page_fault() calls
walk_addr() too, but now it gets l2_gpa as a parameter since during
NPF svm->vmcb->control.exit_info_2 will not point to l2_gva, but l2_gpa
instead. Do I miss something here?

--
			Gleb.

             reply	other threads:[~2010-10-12 13:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-12 13:26 Gleb Natapov [this message]
2010-10-13  8:57 ` question about nested ntp Roedel, Joerg
2010-10-13  9:59   ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101012132611.GA28070@redhat.com \
    --to=gleb@redhat.com \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox