From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: question about nested ntp Date: Tue, 12 Oct 2010 15:26:11 +0200 Message-ID: <20101012132611.GA28070@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: joerg.roedel@amd.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28175 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932287Ab0JLN0O (ORCPT ); Tue, 12 Oct 2010 09:26:14 -0400 Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: Hi Joerg, I have a question about nested ntp code. Comment in init_kvm_nested_mmu() function says "arch.mmu.gva_to_gpa translates l2_gva to l1_gpa". If I read the code correctly at the time of nested guest execution arch.mmu.gva_to_gpa() points to one of paging*_gva_to_gpa() variants. The function calls walk_addr() with provided address which should be l2_gva according to the comment. Now when NPF happens while nested guest runs arch.mmu.page_fault() is called which translates to call to one of paging*_page_fault() variants. paging*_page_fault() calls walk_addr() too, but now it gets l2_gpa as a parameter since during NPF svm->vmcb->control.exit_info_2 will not point to l2_gva, but l2_gpa instead. Do I miss something here? -- Gleb.