[PATCH 1/2] KVM test: Make cache=none the default on KVM autotest runs

[PATCH 1/2] KVM test: Make cache=none the default on KVM autotest runs

[Lucas Meneghel Rodrigues]

cache=none is our supported way of running images, so enforce
this policy on the KVM autotest defaults. It will also make
it easier for people trying to figure out where to change the
cache mode for images.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
---
 client/tests/kvm/tests_base.cfg.sample |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
index 769d750..87fd51d 100644
--- a/client/tests/kvm/tests_base.cfg.sample
+++ b/client/tests/kvm/tests_base.cfg.sample
@@ -35,6 +35,7 @@ smp = 1
 mem = 512
 image_size = 10G
 drive_index_image1 = 0
+drive_cache = none
 shell_port = 22
 display = vnc
 drive_index_cd1 = 1
-- 
1.7.2.3

[PATCH 2/2] KVM test: Remove image_boot=yes from virtio_blk variant

[Lucas Meneghel Rodrigues]

Recent qemu can handle virtio without boot without boot=on,
and qemu.git will simply state the option as invalid. So
remove it from the default config on tests_base.cfg, just
leave it there commented in case someone is testing older
versions.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
---
 client/tests/kvm/tests_base.cfg.sample |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
index 87fd51d..f8c70fe 100644
--- a/client/tests/kvm/tests_base.cfg.sample
+++ b/client/tests/kvm/tests_base.cfg.sample
@@ -1914,7 +1914,9 @@ variants:
         drive_format=scsi
     - virtio_blk:
         drive_format=virtio
-        image_boot=yes
+        # Some older qemu might need image_boot=yes for virtio images to work.
+        # Please uncomment the below if that is the case.
+        #image_boot=yes
 
 
 virtio_net|virtio_blk|e1000|balloon_check:
-- 
1.7.2.3

Re: [PATCH 2/2] KVM test: Remove image_boot=yes from virtio_blk variant

[pradeep]

On Thu, 14 Oct 2010 01:24:12 -0300
Lucas Meneghel Rodrigues <lmr@redhat.com> wrote:

> Recent qemu can handle virtio without boot without boot=on,
> and qemu.git will simply state the option as invalid. So
> remove it from the default config on tests_base.cfg, just
> leave it there commented in case someone is testing older
> versions.


But older qemu shipped with distros might require "boot=on".
Its good to check qemu version.


Thanks
Pradeep

[AUTOTEST] [PATCH 1/2] KVM : ping6 test

[pradeep]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

This patch is for Ping6 testing

    * ping6 with various message sizes guest to/from local/remote host
      using link-local addresses 
      By default IPv6 seems to be disabled  on virbr0. Enable it by
      doing echo 0 > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6
    
Please find the below attached patch.

Thanks
Pradeep



[-- Attachment #2: ipv6_1 --]
[-- Type: application/octet-stream, Size: 1457 bytes --]

Signed-off-by: Pradeep K Surisetty <psuriset@linux.vnet.ibm.com>
---
--- autotest/client/tests/kvm/tests/ping.py	2010-10-14 14:20:52.523791118 +0530
+++ autotest_new/client/tests/kvm/tests/ping.py	2010-10-14 14:46:57.711797139 +0530
@@ -1,5 +1,6 @@
-import logging
+import logging, time
 from autotest_lib.client.common_lib import error
+from autotest_lib.client.bin import utils
 import kvm_test_utils
 
 
@@ -27,10 +28,18 @@ def run_ping(test, params, env):
     nics = params.get("nics").split()
     strict_check = params.get("strict_check", "no") == "yes"
 
+    address_type = params.get("address_type")
+    #By default IPv6 seems to be disabled on virbr0. 
+    ipv6_cmd = "echo %s > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6"
+
     packet_size = [0, 1, 4, 48, 512, 1440, 1500, 1505, 4054, 4055, 4096, 4192,
                    8878, 9000, 32767, 65507]
 
     try:
+        if address_type == "ipv6":
+                utils.run(ipv6_cmd % "0" )
+                time.sleep(5)
+
         for i, nic in enumerate(nics):
             ip = vm.get_address(i)
             if not ip:
@@ -68,5 +77,9 @@ def run_ping(test, params, env):
                 if status != 0:
                     raise error.TestFail("Ping returns non-zero value %s" %
                                          output)
+        if address_type == "ipv6":
+                utils.run(ipv6_cmd % "1" )
+                time.sleep(5)
+
     finally:
         session.close()
---

[-- Attachment #3: Type: text/plain, Size: 152 bytes --]

_______________________________________________
Autotest mailing list
Autotest@test.kernel.org
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Re: [AUTOTEST] [PATCH 1/2] KVM : ping6 test

[Amos Kong]

On Thu, Oct 14, 2010 at 02:56:59PM +0530, pradeep wrote:
> This patch is for Ping6 testing
> 
>     * ping6 with various message sizes guest to/from local/remote host
>       using link-local addresses 
>       By default IPv6 seems to be disabled  on virbr0. Enable it by
>       doing echo 0 > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6
>     
> Please find the below attached patch

We also need update related code in kvm_test_utils.py, and consider the difference of
'ping' and 'ping6'.

> Signed-off-by: Pradeep K Surisetty <psuriset@linux.vnet.ibm.com>
> ---
> --- autotest/client/tests/kvm/tests/ping.py	2010-10-14 14:20:52.523791118 +0530
> +++ autotest_new/client/tests/kvm/tests/ping.py	2010-10-14 14:46:57.711797139 +0530
> @@ -1,5 +1,6 @@
> -import logging
> +import logging, time
>  from autotest_lib.client.common_lib import error
> +from autotest_lib.client.bin import utils
>  import kvm_test_utils
>  
>  
> @@ -27,10 +28,18 @@ def run_ping(test, params, env):
>      nics = params.get("nics").split()
>      strict_check = params.get("strict_check", "no") == "yes"
>  
> +    address_type = params.get("address_type")
> +    #By default IPv6 seems to be disabled on virbr0. 
> +    ipv6_cmd = "echo %s > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6"

We may use other bridge, so 'virbr0', need replace this hardcode name.
We can reference to  'autotest-upstream/client/tests/kvm/scripts/qemu-ifup'
       switch=$(/usr/sbin/brctl show | awk 'NR==2 { print $1 }')


> +
>      packet_size = [0, 1, 4, 48, 512, 1440, 1500, 1505, 4054, 4055, 4096, 4192,
>                     8878, 9000, 32767, 65507]
>  
>      try:
> +        if address_type == "ipv6":
> +                utils.run(ipv6_cmd % "0" )
> +                time.sleep(5)
> +
>          for i, nic in enumerate(nics):
>              ip = vm.get_address(i)
>              if not ip:
> @@ -68,5 +77,9 @@ def run_ping(test, params, env):
>                  if status != 0:
>                      raise error.TestFail("Ping returns non-zero value %s" %
>                                           output)
> +        if address_type == "ipv6":
> +                utils.run(ipv6_cmd % "1" )
> +                time.sleep(5)
> +
>      finally:
>          session.close()
> ---

Re: [Autotest] [AUTOTEST] [PATCH 1/2] KVM : ping6 test

[pradeep]

On Thu, 14 Oct 2010 18:05:04 +0800
Amos Kong <akong@redhat.com> wrote:

> On Thu, Oct 14, 2010 at 02:56:59PM +0530, pradeep wrote:
> > This patch is for Ping6 testing
> > 
> >     * ping6 with various message sizes guest to/from local/remote
> > host using link-local addresses 
> >       By default IPv6 seems to be disabled  on virbr0. Enable it by
> >       doing echo 0 > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6
> >     
> > Please find the below attached patch
> 
> We also need update related code in kvm_test_utils.py, and consider
> the difference of 'ping' and 'ping6'.


ping6 test again calls same ping, and enables ipv6.
so we dont need to make any changes in kvm_test_utils.py for
ping6.

> 
> > Signed-off-by: Pradeep K Surisetty <psuriset@linux.vnet.ibm.com>
> > ---
> > --- autotest/client/tests/kvm/tests/ping.py	2010-10-14
> > 14:20:52.523791118 +0530 +++
> > autotest_new/client/tests/kvm/tests/ping.py	2010-10-14
> > 14:46:57.711797139 +0530 @@ -1,5 +1,6 @@ -import logging
> > +import logging, time
> >  from autotest_lib.client.common_lib import error
> > +from autotest_lib.client.bin import utils
> >  import kvm_test_utils
> >  
> >  
> > @@ -27,10 +28,18 @@ def run_ping(test, params, env):
> >      nics = params.get("nics").split()
> >      strict_check = params.get("strict_check", "no") == "yes"
> >  
> > +    address_type = params.get("address_type")
> > +    #By default IPv6 seems to be disabled on virbr0. 
> > +    ipv6_cmd = "echo %s
> > > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6"
> 
> We may use other bridge, so 'virbr0', need replace this hardcode name.
> We can reference to
> 'autotest-upstream/client/tests/kvm/scripts/qemu-ifup'
> switch=$(/usr/sbin/brctl show | awk 'NR==2 { print $1 }')
> 
> 
> > +
> >      packet_size = [0, 1, 4, 48, 512, 1440, 1500, 1505, 4054, 4055,
> > 4096, 4192, 8878, 9000, 32767, 65507]
> >  
> >      try:
> > +        if address_type == "ipv6":
> > +                utils.run(ipv6_cmd % "0" )
> > +                time.sleep(5)
> > +
> >          for i, nic in enumerate(nics):
> >              ip = vm.get_address(i)
> >              if not ip:
> > @@ -68,5 +77,9 @@ def run_ping(test, params, env):
> >                  if status != 0:
> >                      raise error.TestFail("Ping returns non-zero
> > value %s" % output)
> > +        if address_type == "ipv6":
> > +                utils.run(ipv6_cmd % "1" )
> > +                time.sleep(5)
> > +
> >      finally:
> >          session.close()
> > ---
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

[AUTOTEST] [PATCH 1/2] KVM : ping6 test

[pradeep]

[-- Attachment #1: Type: text/plain, Size: 99 bytes --]

Changes for tests_base.cfg to include ping6 test

Please find below attached patch.

Thanks
Pradeep

[-- Attachment #2: ipv6_2 --]
[-- Type: application/octet-stream, Size: 602 bytes --]

Signed-off-by: Pradeep K Surisetty <psuriset@linux.vnet.ibm.com>
---
--- autotest/client/tests/kvm/tests_base.cfg.sample	2010-10-14 14:20:52.519790819 +0530
+++ autotest_new/client/tests/kvm/tests_base.cfg.sample	2010-10-14 14:26:34.496804587 +0530
@@ -475,6 +475,13 @@ variants:
         type = ping
         counts = 100
         flood_minutes = 10
+	address_type = ipv4
+
+    - ping6: install setup unattended_install.cdrom
+        type = ping
+        counts = 100
+        flood_minutes = 10
+	address_type = ipv6
 
     - jumbo: install setup unattended_install.cdrom
         type = jumbo
---