From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] KVM: Fix signature of kvm_iommu_map_pages stub
Date: Mon, 18 Oct 2010 11:04:00 -0200
Message-ID: <20101018130400.GD29108@amt.cnet>
References: <4CB6F088.2060007@siemens.com>
 <4CB6FB07.10209@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
	Joerg Roedel <joerg.roedel@amd.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:51511 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754333Ab0JRNKZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 18 Oct 2010 09:10:25 -0400
Content-Disposition: inline
In-Reply-To: <4CB6FB07.10209@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Oct 14, 2010 at 02:43:51PM +0200, Jan Kiszka wrote:
> Am 14.10.2010 13:59, Jan Kiszka wrote:
> > Breaks otherwise if CONFIG_IOMMU_API is not set.
> 
> Actually, it only broke a special local version. It doesn't break with
> current KVM due to
> 
> [__kvm_set_memory_region:]
> #ifdef CONFIG_DMAR
> 	/* map the pages in iommu page table */
> 	if (npages) {
> 		r = kvm_iommu_map_pages(kvm, &new);
> 		if (r)
> 			goto out_free;
> 	}
> #endif
> 
> And CONFIG_IOMMU_API is set when CONFIG_DMAR is enabled. But do we only
> need this call on Intel?

On CONFIG_AMD_IOMMU too. It should be conditional on CONFIG_IOMMU_API.