Re: [PATCH] KVM: Drop CONFIG_DMAR dependency around kvm_iommu_map_pages

["Roedel, Joerg" <Joerg.Roedel@amd.com>]

On Mon, Oct 18, 2010 at 10:34:01AM -0400, Jan Kiszka wrote:
> Am 18.10.2010 15:48, Roedel, Joerg wrote:
> > On Mon, Oct 18, 2010 at 09:38:40AM -0400, Jan Kiszka wrote:
> >> We also have to call kvm_iommu_map_pages for CONFIG_AMD_IOMMU. So drop
> >> the dependency on Intel IOMMU, kvm_iommu_map_pages will be a nop anyway
> >> if CONFIG_IOMMU_API is not defined.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > Acked-by: Joerg Roedel <joerg.roedel@amd.com>
> > 
> > Is this also a -stable candidate?
> 
> I can't seriously judge as I was not able to test its effect on real
> hardware.
> 
> The patch seems to apply (with mechanical adjustments) down to 2.6.32.
> If it is considered for stable, it will also take [1] to avoid build
> breakage without CONFIG_IOMMU_API.
> 
> Jan
> 
> [1] http://thread.gmane.org/gmane.comp.emulators.kvm.devel/60954

Looks trivial enough. I would consider both patches as -stable material.

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632