From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: [PATCH] KVM: Drop CONFIG_DMAR dependency around kvm_iommu_map_pages Date: Mon, 18 Oct 2010 16:55:57 +0200 Message-ID: <20101018145557.GB21383@amd.com> References: <4CBC4DE0.6010607@siemens.com> <20101018134821.GA21383@amd.com> <4CBC5AD9.209@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Avi Kivity , Marcelo Tosatti , kvm To: Jan Kiszka Return-path: Received: from am1ehsobe006.messaging.microsoft.com ([213.199.154.209]:25766 "EHLO AM1EHSOBE006.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755564Ab0JRPLJ (ORCPT ); Mon, 18 Oct 2010 11:11:09 -0400 Content-Disposition: inline In-Reply-To: <4CBC5AD9.209@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Oct 18, 2010 at 10:34:01AM -0400, Jan Kiszka wrote: > Am 18.10.2010 15:48, Roedel, Joerg wrote: > > On Mon, Oct 18, 2010 at 09:38:40AM -0400, Jan Kiszka wrote: > >> We also have to call kvm_iommu_map_pages for CONFIG_AMD_IOMMU. So drop > >> the dependency on Intel IOMMU, kvm_iommu_map_pages will be a nop anyway > >> if CONFIG_IOMMU_API is not defined. > >> > >> Signed-off-by: Jan Kiszka > > > > Acked-by: Joerg Roedel > > > > Is this also a -stable candidate? > > I can't seriously judge as I was not able to test its effect on real > hardware. > > The patch seems to apply (with mechanical adjustments) down to 2.6.32. > If it is considered for stable, it will also take [1] to avoid build > breakage without CONFIG_IOMMU_API. > > Jan > > [1] http://thread.gmane.org/gmane.comp.emulators.kvm.devel/60954 Looks trivial enough. I would consider both patches as -stable material. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632