From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Avi Kivity <avi@redhat.com>,
kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: Drop CONFIG_DMAR dependency around kvm_iommu_map_pages
Date: Tue, 19 Oct 2010 10:58:47 -0200 [thread overview]
Message-ID: <20101019125847.GA3649@amt.cnet> (raw)
In-Reply-To: <20101018145557.GB21383@amd.com>
On Mon, Oct 18, 2010 at 04:55:57PM +0200, Roedel, Joerg wrote:
> On Mon, Oct 18, 2010 at 10:34:01AM -0400, Jan Kiszka wrote:
> > Am 18.10.2010 15:48, Roedel, Joerg wrote:
> > > On Mon, Oct 18, 2010 at 09:38:40AM -0400, Jan Kiszka wrote:
> > >> We also have to call kvm_iommu_map_pages for CONFIG_AMD_IOMMU. So drop
> > >> the dependency on Intel IOMMU, kvm_iommu_map_pages will be a nop anyway
> > >> if CONFIG_IOMMU_API is not defined.
> > >>
> > >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > >
> > > Acked-by: Joerg Roedel <joerg.roedel@amd.com>
> > >
> > > Is this also a -stable candidate?
> >
> > I can't seriously judge as I was not able to test its effect on real
> > hardware.
> >
> > The patch seems to apply (with mechanical adjustments) down to 2.6.32.
> > If it is considered for stable, it will also take [1] to avoid build
> > breakage without CONFIG_IOMMU_API.
> >
> > Jan
> >
> > [1] http://thread.gmane.org/gmane.comp.emulators.kvm.devel/60954
>
> Looks trivial enough. I would consider both patches as -stable material.
>
> Joerg
Applied both with stable tag, thanks Jan.
prev parent reply other threads:[~2010-10-19 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 13:38 [PATCH] KVM: Drop CONFIG_DMAR dependency around kvm_iommu_map_pages Jan Kiszka
2010-10-18 13:48 ` Roedel, Joerg
2010-10-18 14:34 ` Jan Kiszka
2010-10-18 14:55 ` Roedel, Joerg
2010-10-19 12:58 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019125847.GA3649@amt.cnet \
--to=mtosatti@redhat.com \
--cc=Joerg.Roedel@amd.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox