From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] KVM: Drop CONFIG_DMAR dependency around kvm_iommu_map_pages Date: Tue, 19 Oct 2010 10:58:47 -0200 Message-ID: <20101019125847.GA3649@amt.cnet> References: <4CBC4DE0.6010607@siemens.com> <20101018134821.GA21383@amd.com> <4CBC5AD9.209@siemens.com> <20101018145557.GB21383@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kiszka , Avi Kivity , kvm To: "Roedel, Joerg" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46034 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933331Ab0JSNPN (ORCPT ); Tue, 19 Oct 2010 09:15:13 -0400 Content-Disposition: inline In-Reply-To: <20101018145557.GB21383@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Oct 18, 2010 at 04:55:57PM +0200, Roedel, Joerg wrote: > On Mon, Oct 18, 2010 at 10:34:01AM -0400, Jan Kiszka wrote: > > Am 18.10.2010 15:48, Roedel, Joerg wrote: > > > On Mon, Oct 18, 2010 at 09:38:40AM -0400, Jan Kiszka wrote: > > >> We also have to call kvm_iommu_map_pages for CONFIG_AMD_IOMMU. So drop > > >> the dependency on Intel IOMMU, kvm_iommu_map_pages will be a nop anyway > > >> if CONFIG_IOMMU_API is not defined. > > >> > > >> Signed-off-by: Jan Kiszka > > > > > > Acked-by: Joerg Roedel > > > > > > Is this also a -stable candidate? > > > > I can't seriously judge as I was not able to test its effect on real > > hardware. > > > > The patch seems to apply (with mechanical adjustments) down to 2.6.32. > > If it is considered for stable, it will also take [1] to avoid build > > breakage without CONFIG_IOMMU_API. > > > > Jan > > > > [1] http://thread.gmane.org/gmane.comp.emulators.kvm.devel/60954 > > Looks trivial enough. I would consider both patches as -stable material. > > Joerg Applied both with stable tag, thanks Jan.