Re: [PATCH] virtio: Use ioeventfd for virtqueue notify

Michael S. Tsirkin
2010-10-19T13:49:36Z

On Tue, Oct 19, 2010 at 02:44:35PM +0100, Stefan Hajnoczi wrote:
> On Tue, Oct 19, 2010 at 2:35 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Oct 19, 2010 at 08:12:42AM -0500, Anthony Liguori wrote:
> >> On 10/19/2010 08:07 AM, Stefan Hajnoczi wrote:
> >> >Is there anything stopping this patch from being merged?
> >>
> >> Michael, any objections?  If not, I'll merge it.
> >
> > I don't really understand what's going on there.  The extra state in
> > notifiers especially scares me. If you do and are comfortable with the
> > code, go ahead :)
>
> I'm happy to address your comments. The state machine was a bit icky
> but I don't see a way around it.

I think the situation is similar to irqfd in qemu-kvm - take a look
there, specifically msix mask notifiers.

--
MST