From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio: Use ioeventfd for virtqueue notify Date: Tue, 19 Oct 2010 15:35:55 +0200 Message-ID: <20101019133555.GC18341@redhat.com> References: <1285855312-11739-1-git-send-email-stefanha@linux.vnet.ibm.com> <20101019130710.GA3906@stefan-thinkpad.transitives.com> <4CBD994A.4060500@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, kvm@vger.kernel.org, Anthony Liguori , Khoa Huynh , sri@linux.vnet.ibm.com, Steve Dobbelstein To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25856 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756337Ab0JSNmS (ORCPT ); Tue, 19 Oct 2010 09:42:18 -0400 Content-Disposition: inline In-Reply-To: <4CBD994A.4060500@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Oct 19, 2010 at 08:12:42AM -0500, Anthony Liguori wrote: > On 10/19/2010 08:07 AM, Stefan Hajnoczi wrote: > >Is there anything stopping this patch from being merged? > > Michael, any objections? If not, I'll merge it. I don't really understand what's going on there. The extra state in notifiers especially scares me. If you do and are comfortable with the code, go ahead :) -- MST