From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio: Use ioeventfd for virtqueue notify Date: Tue, 19 Oct 2010 15:43:15 +0200 Message-ID: <20101019134315.GA18740@redhat.com> References: <1285855312-11739-1-git-send-email-stefanha@linux.vnet.ibm.com> <20101019130710.GA3906@stefan-thinkpad.transitives.com> <4CBD994A.4060500@linux.vnet.ibm.com> <20101019133555.GC18341@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Anthony Liguori , Stefan Hajnoczi , qemu-devel@nongnu.org, kvm@vger.kernel.org, Anthony Liguori , Khoa Huynh , sri@linux.vnet.ibm.com, Steve Dobbelstein To: Stefan Hajnoczi Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28641 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943Ab0JSNtg (ORCPT ); Tue, 19 Oct 2010 09:49:36 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Oct 19, 2010 at 02:44:35PM +0100, Stefan Hajnoczi wrote: > On Tue, Oct 19, 2010 at 2:35 PM, Michael S. Tsirkin = wrote: > > On Tue, Oct 19, 2010 at 08:12:42AM -0500, Anthony Liguori wrote: > >> On 10/19/2010 08:07 AM, Stefan Hajnoczi wrote: > >> >Is there anything stopping this patch from being merged? > >> > >> Michael, any objections? =A0If not, I'll merge it. > > > > I don't really understand what's going on there. =A0The extra state= in > > notifiers especially scares me. If you do and are comfortable with = the > > code, go ahead :) >=20 > I'm happy to address your comments. The state machine was a bit icky > but I don't see a way around it. I think the situation is similar to irqfd in qemu-kvm - take a look there, specifically msix mask notifiers. --=20 MST