From: Andi Kleen <andi@firstfloor.org>
To: Avi Kivity <avi@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
mtosatti@redhat.com, kvm@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] KVM: Move KVM context switch into own function
Date: Wed, 20 Oct 2010 18:20:41 +0200 [thread overview]
Message-ID: <20101020162041.GF20124@basil.fritz.box> (raw)
In-Reply-To: <4CBF14DB.5020109@redhat.com>
On Wed, Oct 20, 2010 at 06:12:11PM +0200, Avi Kivity wrote:
> On 10/20/2010 05:56 PM, Andi Kleen wrote:
> >From: Andi Kleen<ak@linux.intel.com>
> >
> >gcc 4.5 with some special options is able to duplicate the VMX
> >context switch asm in vmx_vcpu_run(). This results in a compile error
> >because the inline asm sequence uses an on local label. The non local
> >label is needed because other code wants to set up the return address.
> >
>
> Curious, any idea why gcc does that? I guess it's the unlikely()
> near the top.
Don't know why, i wasn't motivated to go through its debugging dumps
for this. But strictly the problem could always happen,
not even a "volatile" stops that.
-Andi
next prev parent reply other threads:[~2010-10-20 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 15:56 [PATCH] KVM: Move KVM context switch into own function Andi Kleen
2010-10-20 16:12 ` Avi Kivity
2010-10-20 16:20 ` Andi Kleen [this message]
2010-10-21 17:28 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020162041.GF20124@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox