From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] msix: fix irqchip breakage Date: Wed, 20 Oct 2010 15:37:24 -0200 Message-ID: <20101020173724.GA946@amt.cnet> References: <20101020050937.GA10401@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19515 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437Ab0JTRjE (ORCPT ); Wed, 20 Oct 2010 13:39:04 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9KHd4Fk012679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Oct 2010 13:39:04 -0400 Content-Disposition: inline In-Reply-To: <20101020050937.GA10401@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 20, 2010 at 07:09:37AM +0200, Michael S. Tsirkin wrote: > msix.c doesn't include linux kvm header anymore, so > IRQCHIP macro is never defined, which resulted in > a broken msix support. As a fix, stub out kvm_set_irq > and remove the remaining ifdefs. > > Signed-off-by: Michael S. Tsirkin > --- > hw/msix.c | 2 -- > kvm-stub.c | 6 ++++++ > kvm.h | 2 ++ > qemu-kvm.h | 1 - > 4 files changed, 8 insertions(+), 3 deletions(-) Applied both, thanks.