From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 0/8][v2] MSI-X mask emulation support for assigned device Date: Wed, 20 Oct 2010 17:02:24 -0200 Message-ID: <20101020190224.GA4089@amt.cnet> References: <1287563192-29685-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org, "Michael S. Tsirkin" To: Sheng Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41446 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754455Ab0JTTCa (ORCPT ); Wed, 20 Oct 2010 15:02:30 -0400 Content-Disposition: inline In-Reply-To: <1287563192-29685-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 20, 2010 at 04:26:24PM +0800, Sheng Yang wrote: > Here is v2. > > Changelog: > > v1->v2 > > The major change from v1 is I've added the in-kernel MSI-X mask emulation > support, as well as adding shortcuts for reading MSI-X table. > > I've taken Michael's advice to use mask/unmask directly, but unsure about > exporting irq_to_desc() for module... > > Also add flush_work() according to Marcelo's comments. > > Sheng Yang (8): > PCI: MSI: Move MSI-X entry definition to pci_regs.h > irq: Export irq_to_desc() to modules > KVM: x86: Enable ENABLE_CAP capability for x86 > KVM: Move struct kvm_io_device to kvm_host.h > KVM: Add kvm_get_irq_routing_entry() func > KVM: assigned dev: Preparation for mask support in userspace > KVM: assigned dev: Introduce io_device for MSI-X MMIO accessing > KVM: Emulation MSI-X mask bits for assigned devices Why does the current scheme, without msix per-vector mask support, is functional at all? Luck?