From: Marcelo Tosatti <mtosatti@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: avi@redhat.com, kvm@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] KVM: Move KVM context switch into own function
Date: Thu, 21 Oct 2010 15:28:13 -0200 [thread overview]
Message-ID: <20101021172813.GA27232@amt.cnet> (raw)
In-Reply-To: <1287590177-25094-1-git-send-email-andi@firstfloor.org>
On Wed, Oct 20, 2010 at 05:56:17PM +0200, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> gcc 4.5 with some special options is able to duplicate the VMX
> context switch asm in vmx_vcpu_run(). This results in a compile error
> because the inline asm sequence uses an on local label. The non local
> label is needed because other code wants to set up the return address.
>
> This patch moves the asm code into an own function and marks
> that explicitely noinline to avoid this problem.
>
> Better would be probably to just move it into an .S file.
>
> The diff looks worse than the change really is, it's all just
> code movement and no logic change.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Applied, thanks.
prev parent reply other threads:[~2010-10-21 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 15:56 [PATCH] KVM: Move KVM context switch into own function Andi Kleen
2010-10-20 16:12 ` Avi Kivity
2010-10-20 16:20 ` Andi Kleen
2010-10-21 17:28 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021172813.GA27232@amt.cnet \
--to=mtosatti@redhat.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox