From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] KVM: Move KVM context switch into own function Date: Thu, 21 Oct 2010 15:28:13 -0200 Message-ID: <20101021172813.GA27232@amt.cnet> References: <1287590177-25094-1-git-send-email-andi@firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, kvm@vger.kernel.org, Andi Kleen To: Andi Kleen Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15958 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755289Ab0JUR3f (ORCPT ); Thu, 21 Oct 2010 13:29:35 -0400 Content-Disposition: inline In-Reply-To: <1287590177-25094-1-git-send-email-andi@firstfloor.org> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 20, 2010 at 05:56:17PM +0200, Andi Kleen wrote: > From: Andi Kleen > > gcc 4.5 with some special options is able to duplicate the VMX > context switch asm in vmx_vcpu_run(). This results in a compile error > because the inline asm sequence uses an on local label. The non local > label is needed because other code wants to set up the return address. > > This patch moves the asm code into an own function and marks > that explicitely noinline to avoid this problem. > > Better would be probably to just move it into an .S file. > > The diff looks worse than the change really is, it's all just > code movement and no logic change. > > Signed-off-by: Andi Kleen Applied, thanks.