Re: [PATCH 2/2] msix: Pull in config.h for CONFIG_KVM

Michael S. Tsirkin
2010-10-23T17:36:17Z

On Sat, Oct 23, 2010 at 10:52:43AM -0600, Alex Williamson wrote:
> On Sat, 2010-10-23 at 18:16 +0200, Michael S. Tsirkin wrote:
> > On Fri, Oct 22, 2010 at 02:40:39PM -0600, Alex Williamson wrote:
> > > We need to pull in config.h or else kvm.h doesn't pull in
> > > linux/config.h, which we need if we ever want KVM_CAP_IRQCHIP
> > > defined. This requires moving the object over to Makefile.target
> > > or else we can't find config-target.h
> > >
> > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> >
> > Why? We just moved it from .target to .objs, see
> > 889e30cc18e21f2091b77267dca8096d7dd34f8b.
>
> Maybe that's why it used to work. When building in the qemu-kvm.git
> tree, I'm not getting CONFIG_KVM defined, which means I'm not getting
> KVM_CAP_IRQCHIP defined, which results in msix_irq_entries not being
> allocated. Then when I call msix_vector_use, I get a seg fault.
> Something is broken there. Thanks,
>
> Alex

This is hopefully fixed in the latest bits.
bd8b215bce453706c3951460cc7e6627ccb90314

--
MST