From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 2/2] msix: Pull in config.h for CONFIG_KVM Date: Sat, 23 Oct 2010 22:38:02 +0200 Message-ID: <20101023203802.GA14723@redhat.com> References: <20101022193845.10161.52907.stgit@s20.home> <20101022204037.10161.83407.stgit@s20.home> <20101023161633.GA11488@redhat.com> <1287852763.5129.5.camel@x201> <20101023172945.GD11488@redhat.com> <1287859364.5129.12.camel@x201> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31233 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756942Ab0JWUoc (ORCPT ); Sat, 23 Oct 2010 16:44:32 -0400 Content-Disposition: inline In-Reply-To: <1287859364.5129.12.camel@x201> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Oct 23, 2010 at 12:42:44PM -0600, Alex Williamson wrote: > On Sat, 2010-10-23 at 19:29 +0200, Michael S. Tsirkin wrote: > > On Sat, Oct 23, 2010 at 10:52:43AM -0600, Alex Williamson wrote: > > > On Sat, 2010-10-23 at 18:16 +0200, Michael S. Tsirkin wrote: > > > > On Fri, Oct 22, 2010 at 02:40:39PM -0600, Alex Williamson wrote: > > > > > We need to pull in config.h or else kvm.h doesn't pull in > > > > > linux/config.h, which we need if we ever want KVM_CAP_IRQCHIP > > > > > defined. This requires moving the object over to Makefile.target > > > > > or else we can't find config-target.h > > > > > > > > > > Signed-off-by: Alex Williamson > > > > > > > > Why? We just moved it from .target to .objs, see > > > > 889e30cc18e21f2091b77267dca8096d7dd34f8b. > > > > > > Maybe that's why it used to work. When building in the qemu-kvm.git > > > tree, I'm not getting CONFIG_KVM defined, which means I'm not getting > > > KVM_CAP_IRQCHIP defined, which results in msix_irq_entries not being > > > allocated. Then when I call msix_vector_use, I get a seg fault. > > > Something is broken there. Thanks, > > > > > > Alex > > > > This is hopefully fixed in the latest bits. > > bd8b215bce453706c3951460cc7e6627ccb90314 > > Nope, my tree includes that. It's not kvm_set_irq, it's kvm_msix_add, > which dereferences msix_irq_entries, which is only allocated in > msix_init if KVM_CAP_IRQCHIP is defined, which it's not. Maybe you also > meant to remove the ifdef from msix_init? I also note there's another > in msix_notify. Thanks, > > Alex Not sure what's wrong: $git grep KVM_CAP_IRQCHIP origin/master -- hw/msix.c $ http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=blob;f=hw/msix.c;hb=HEAD also does not show any ifdefs. -- MST