From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 6/8] KVM: assigned dev: Preparation for mask support in userspace Date: Sun, 24 Oct 2010 14:23:20 +0200 Message-ID: <20101024122320.GB18200@redhat.com> References: <1287563192-29685-1-git-send-email-sheng@linux.intel.com> <1287563192-29685-7-git-send-email-sheng@linux.intel.com> <20101022145313.GA24078@amt.cnet> <201010242019.09655.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , Avi Kivity , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35189 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932574Ab0JXMaB (ORCPT ); Sun, 24 Oct 2010 08:30:01 -0400 Content-Disposition: inline In-Reply-To: <201010242019.09655.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Oct 24, 2010 at 08:19:09PM +0800, Sheng Yang wrote: > > > > You need a guarantee that MSIX per-vector mask is used for > > disable_irq/enable_irq, right? I can't see how this provides it. > > This one meant to directly operate the mask/unmask bit of the MSI-X table, to > emulate the mask/unmask behavior that guest want. In the previous patch I used > enable_irq()/disable_irq(), but they won't directly operate the MSI-X table unless > it's necessary, and Michael want to read the table in userspace then he prefer > using mask/unmask directly. As I said, the main problem was really that the implementation proposed only works for interrupts used by assigned devices. I would like for it to work for irqfd as well. -- MST