From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] kvm: get rid of srcu idx
Date: Mon, 25 Oct 2010 11:52:29 -0200
Message-ID: <20101025135229.GA3392@amt.cnet>
References: <20101024171610.GA24375@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:34192 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751285Ab0JYMxG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 25 Oct 2010 08:53:06 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9PCr5Y4024722
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Mon, 25 Oct 2010 08:53:05 -0400
Content-Disposition: inline
In-Reply-To: <20101024171610.GA24375@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Oct 24, 2010 at 07:16:10PM +0200, Michael S. Tsirkin wrote:
> srcu_idx is easy to misuse as it can not be used
> in nested srcu_read_lock calls.  Switch to local
> index to make correctness easier to verify.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> ---

Looks good to me.

Not needed for -stable, i don't see a problem with the current
code?