public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm <kvm@vger.kernel.org>
Subject: qemu-kvm-x86: fix e820 reservation
Date: Mon, 25 Oct 2010 21:10:10 -0200	[thread overview]
Message-ID: <20101025231010.GA25262@amt.cnet> (raw)


e820 reserved range should start at 0xfeffc000, which includes
the EPT identity page, not 0xfeffd000.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c
index ec7d419..20b7d6d 100644
--- a/qemu-kvm-x86.c
+++ b/qemu-kvm-x86.c
@@ -32,13 +32,6 @@ extern unsigned int kvm_shadow_memory;
 int kvm_set_tss_addr(kvm_context_t kvm, unsigned long addr)
 {
     int r;
-    /*
-     * Tell fw_cfg to notify the BIOS to reserve the range.
-     */
-    if (e820_add_entry(addr, 0x4000, E820_RESERVED) < 0) {
-        perror("e820_add_entry() table is full");
-        exit(1);
-    }
 
     r = kvm_vm_ioctl(kvm_state, KVM_SET_TSS_ADDR, addr);
     if (r < 0) {
@@ -146,6 +139,14 @@ int kvm_arch_create(kvm_context_t kvm, unsigned long phys_mem_bytes,
         return r;
     }
 
+    /*
+     * Tell fw_cfg to notify the BIOS to reserve the range.
+     */
+    if (e820_add_entry(0xfeffc000, 0x4000, E820_RESERVED) < 0) {
+        perror("e820_add_entry() table is full");
+        exit(1);
+    }
+
     r = kvm_create_pit(kvm);
     if (r < 0) {
         return r;


                 reply	other threads:[~2010-10-25 23:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101025231010.GA25262@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox