From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Olsa Subject: Re: [PATCH 2/3] kernel,cred,kvm,security - removing superfluous rcu_read_lock_held check Date: Tue, 2 Nov 2010 08:21:45 +0100 Message-ID: <20101102072145.GA1871@jolsa.brq.redhat.com> References: <1288638909-10541-1-git-send-email-jolsa@redhat.com> <1288638909-10541-3-git-send-email-jolsa@redhat.com> <4CCF424F.3050205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: paul.moore-VXdhtT5mjnY@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, dipankar-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org, johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <4CCF424F.3050205-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: kvm.vger.kernel.org On Mon, Nov 01, 2010 at 11:42:23PM +0100, Paolo Bonzini wrote: > On 11/01/2010 08:15 PM, Jiri Olsa wrote: > >diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > >index a055742..a90a7e3 100644 > >--- a/include/linux/kvm_host.h > >+++ b/include/linux/kvm_host.h > >@@ -256,7 +256,6 @@ void kvm_put_kvm(struct kvm *kvm); > > static inline struct kvm_memslots *kvm_memslots(struct kvm *kvm) > > { > > return rcu_dereference_check(kvm->memslots, > >- srcu_read_lock_held(&kvm->srcu) > > || lockdep_is_held(&kvm->slots_lock)); > > } > > > > This is an srcu_read_lock_held, which you don't touch here: > > >diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c > >index 9d8e8fb..0956a73 100644 > >--- a/kernel/rcutorture.c > >+++ b/kernel/rcutorture.c > >@@ -807,7 +807,6 @@ static void rcu_torture_timer(unsigned long unused) > > idx = cur_ops->readlock(); > > completed = cur_ops->completed(); > > p = rcu_dereference_check(rcu_torture_current, > >- rcu_read_lock_held() || > > rcu_read_lock_bh_held() || > > rcu_read_lock_sched_held() || > > srcu_read_lock_held(&srcu_ctl)); > > I guess the kvm hunk is the incorrect one? ops, you're right. I overlooked it, please skip the kvm hunk.. thanks, jirka