Re: [RFC PATCH] macvlan: Introduce a PASSTHRU mode to takeover the underlying device

Arnd Bergmann
2010-10-27T14:05:42Z

On Wednesday 27 October 2010, Sridhar Samudrala wrote:
> With the current default macvtap mode, a KVM guest using virtio with
> macvtap backend has the following limitations.
> - cannot change/add a mac address on the guest virtio-net
> - cannot create a vlan device on the guest virtio-net
> - cannot enable promiscuous mode on guest virtio-net
>
> This patch introduces a new mode called 'passthru' when creating a
> macvlan device which allows takeover of the underlying device and
> passing it to a guest using virtio with macvtap backend.
>
> Only one macvlan device is allowed in passthru mode and it inherits
> the mac address from the underlying device and sets it in promiscuous
> mode to receive and forward all the packets.

Interesting approach. It somewhat stretches the definition of the
macvlan concept, but it does sound useful to have.

I was thinking about adding a new tap frontend driver that could
share some code with macvtap and do only the takeover but not
use macvlan as a base. I believe that would be a cleaner abstraction,
but your code has two advantages in that the implementation is much
simpler and that it can share a fair amount of the infrastructure
that we're putting into qemu/libvirt/etc.

Arnd

PS: Please add a Signed-off-by: line when sending a patch, even for
discussion.